Opened 6 years ago

Closed 6 years ago

#15663 closed defect (fixed)

Fix wrong claim about Suter's paper

Reported by: darij Owned by:
Priority: major Milestone: sage-6.1
Component: combinatorics Keywords: partitions, suter slides
Cc: sage-combinat, aschilling, tscrim Merged in:
Authors: Darij Grinberg Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: public/combinat/partitions/suter (Commits) Commit: ead59b3ba745a604302b75e64482f9c0b264ccfd
Dependencies: Stopgaps:

Description (last modified by darij)

I accidentally misunderstood one of the two definitions of Suter slides in his paper and claimed in the docstring that it would conflict with the other. My apologies for that!

I've also modified the doc of dominated_partitions to reflect what the code does. Could have done it the other way round but this sounds more natural.

This branch merges cleanly with my other partitions.py branch (#15428).

Change History (10)

comment:1 Changed 6 years ago by darij

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by darij

  • Description modified (diff)

comment:3 Changed 6 years ago by git

  • Commit changed from ca3ed673893e78ac6ac77aa39675654c6a98d2d8 to 1f53ac63e003728c585fd8021daff63f0e22b62c

Branch pushed to git repo; I updated commit sha1. New commits:

1f53ac6Some review changes to partition.py.

comment:4 Changed 6 years ago by git

  • Commit changed from 1f53ac63e003728c585fd8021daff63f0e22b62c to ead59b3ba745a604302b75e64482f9c0b264ccfd

Branch pushed to git repo; I updated commit sha1. New commits:

ead59b3Fixed doc of young_subgroup() in partition.py.

comment:5 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Hey Darij,

I made some review changes that make the doc a little more reading IMO. If you're happy with my changes, then you can set a positive review.

Best,
Travis

comment:6 Changed 6 years ago by darij

Hi Travis,

thanks a lot for checking these. But if you change some ls to \ells, please do this for all of them.

Regards,
Darij

comment:7 Changed 6 years ago by tscrim

Hey Darij,

I couldn't find any other places in partition.py where l was used except where it is code formatted to reflect the input variable.

Best,
Travis

comment:8 Changed 6 years ago by darij

  • Status changed from needs_review to positive_review

Oooops! There were no ls. I mistook one of my is for an l on cursory reading (good argument in favor of your change).

Positive review; thanks again!

Best regards,
Darij

comment:9 Changed 6 years ago by tscrim

Your welcome,
Travis

comment:10 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.