Opened 7 years ago
Closed 7 years ago
#15663 closed defect (fixed)
Fix wrong claim about Suter's paper
Reported by: | darij | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.1 |
Component: | combinatorics | Keywords: | partitions, suter slides |
Cc: | sage-combinat, aschilling, tscrim | Merged in: | |
Authors: | Darij Grinberg | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | public/combinat/partitions/suter (Commits, GitHub, GitLab) | Commit: | ead59b3ba745a604302b75e64482f9c0b264ccfd |
Dependencies: | Stopgaps: |
Description (last modified by )
I accidentally misunderstood one of the two definitions of Suter slides in his paper and claimed in the docstring that it would conflict with the other. My apologies for that!
I've also modified the doc of dominated_partitions
to reflect what the code does. Could have done it the other way round but this sounds more natural.
This branch merges cleanly with my other partitions.py branch (#15428).
Change History (10)
comment:1 Changed 7 years ago by
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Description modified (diff)
comment:3 Changed 7 years ago by
- Commit changed from ca3ed673893e78ac6ac77aa39675654c6a98d2d8 to 1f53ac63e003728c585fd8021daff63f0e22b62c
comment:4 Changed 7 years ago by
- Commit changed from 1f53ac63e003728c585fd8021daff63f0e22b62c to ead59b3ba745a604302b75e64482f9c0b264ccfd
Branch pushed to git repo; I updated commit sha1. New commits:
ead59b3 | Fixed doc of young_subgroup() in partition.py.
|
comment:5 Changed 7 years ago by
- Reviewers set to Travis Scrimshaw
Hey Darij,
I made some review changes that make the doc a little more reading IMO. If you're happy with my changes, then you can set a positive review.
Best,
Travis
comment:6 Changed 7 years ago by
Hi Travis,
thanks a lot for checking these. But if you change some l
s to \ell
s, please do this for all of them.
Regards,
Darij
comment:7 Changed 7 years ago by
Hey Darij,
I couldn't find any other places in partition.py
where l
was used except where it is code formatted to reflect the input variable.
Best,
Travis
comment:8 Changed 7 years ago by
- Status changed from needs_review to positive_review
Oooops! There were no l
s. I mistook one of my i
s for an l
on cursory reading (good argument in favor of your change).
Positive review; thanks again!
Best regards,
Darij
comment:9 Changed 7 years ago by
Your welcome,
Travis
comment:10 Changed 7 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Some review changes to partition.py.