Opened 7 years ago

Closed 6 years ago

#15660 closed defect (fixed)

PARI LLL speed depends on PARI stack size

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: performance Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: u/rws/ticket/15660 (Commits) Commit: d4842426356568815b80323f8fc6afbb80185ba3
Dependencies: #15653, #15654 Stopgaps:

Description (last modified by jdemeyer)

From a doctest in qqbar.py: 

sage: x = polygen(AA)
sage: %time QQbar.polynomial_root(x^5 - x - 1, CIF(RIF(0.1, 0.2), RIF(1.0, 1.1))).imag().exactify()
CPU times: user 28.33 s, sys: 0.02 s, total: 28.35 s
Wall time: 28.38 s
sage: pari.allocatemem(1<<30)
PARI stack size set to 1073741824 bytes
sage: %time QQbar.polynomial_root(x^5 - x - 1, CIF(RIF(0.1, 0.2), RIF(1.0, 1.1))).imag().exactify()
CPU times: user 2.70 s, sys: 0.15 s, total: 2.85 s
Wall time: 2.84 s

Upstream: ​http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1653

Change History (15)

comment:1 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from QQbar minpoly() speed depends on PARI stack size to QQbar exactify() speed depends on PARI stack size

comment:2 Changed 7 years ago by jdemeyer

  • Summary changed from QQbar exactify() speed depends on PARI stack size to QQbar speed depends on PARI stack size

comment:3 Changed 7 years ago by jdemeyer

  • Summary changed from QQbar speed depends on PARI stack size to PARI LLL speed depends on PARI stack size

comment:4 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Dependencies set to #15653, #15654

comment:5 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/15660
  • Created changed from 01/10/14 10:13:32 to 01/10/14 10:13:32
  • Modified changed from 01/10/14 13:29:07 to 01/10/14 13:29:07

comment:6 Changed 7 years ago by git

  • Commit set to 8c58208549f01a79f03d358e7455178e184820a2

Branch pushed to git repo; I updated commit sha1. New commits:

​8c58208"long time" fixes

comment:7 Changed 7 years ago by jdemeyer

  • Status changed from new to needs_review

New commits:

​7537427Fix conversion of zero p-adics to PARI
​a955e45Speed up PARI determinants when stacksize is small
​b29b0b7Speed up PARI LLL when stacksize is small
​8c58208"long time" fixes

comment:8 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:9 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:10 Changed 7 years ago by rws

  • Status changed from needs_review to needs_work
  • Work issues set to rebase

comment:11 Changed 7 years ago by rws

  • Branch changed from u/jdemeyer/ticket/15660 to u/rws/ticket/15660

comment:12 Changed 7 years ago by rws

  • Commit changed from 8c58208549f01a79f03d358e7455178e184820a2 to d4842426356568815b80323f8fc6afbb80185ba3
  • Status changed from needs_work to needs_review
  • Work issues rebase deleted

New commits:

​d484242Merge branch 'develop' into t/15660/ticket/15660

comment:13 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:14 Changed 6 years ago by jdemeyer

  • Authors Jeroen Demeyer deleted
  • Description modified (diff)
  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

Fixed by #16997.

comment:15 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.