Opened 6 years ago

Closed 6 years ago

#15652 closed defect (fixed)

Always add -fno-strict-aliasing when compiling Cython code

Reported by: jdemeyer Owned by:
Priority: critical Milestone: sage-6.1
Component: build Keywords:
Cc: leif, kini Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/ticket/15652 (Commits) Commit: 5b79c2cfc2f31eee3f9c66a7e8d2a7ccdf4fc5d2
Dependencies: Stopgaps:

Description

As reported for example by leif on #11687, the flag -fno-strict-aliasing should always be added when compiling Cython code. Normally, this flag is added but it disappears when the user has manually set CFLAGS (even if set to "").

Change History (4)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/15652
  • Created changed from 01/09/14 09:56:12 to 01/09/14 09:56:12
  • Modified changed from 01/09/14 09:56:12 to 01/09/14 09:56:12

comment:2 Changed 6 years ago by jdemeyer

  • Status changed from new to needs_review

comment:3 Changed 6 years ago by fbissey

  • Commit set to 5b79c2cfc2f31eee3f9c66a7e8d2a7ccdf4fc5d2
  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looks like one of the oldest thing we have in sage-on-gentoo ebuilds. Except we don't patch setup.py to achieve it. That's one thing I can remove if this goes in. Positive from me.


New commits:

5b79c2cAlways add -fno-strict-aliasing when compiling Cython extensions

comment:4 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.