Opened 7 years ago
Closed 6 years ago
#15651 closed defect (duplicate)
Let MPIR build correctly on Cygwin64
Reported by:  jpflori  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  porting: Cygwin  Keywords:  cygwin spkg mpir 
Cc:  kcrisman, dimpase, tscrim  Merged in:  
Authors:  JeanPierre Flori  Reviewers:  Volker Braun 
Report Upstream:  Fixed upstream, but not in a stable release.  Work issues:  
Branch:  u/jpflori/ticket/15651 (Commits, GitHub, GitLab)  Commit:  02866244b8b7ec0d9abb478ff9ba4a7a8b39cbed 
Dependencies:  #15365, #14648  Stopgaps: 
Description
We have to modify the ABI tricks in our spkginstal script, but also patch MPIR so that it uses correct assembly (see upstream commits at https://github.com/wbhart/mpir/commits/master/configure.ac).
Change History (14)
comment:1 Changed 7 years ago by
 Branch set to u/jpflori/ticket/15651
 Commit set to 09276715c5826609a87d21ae0947b30f6e5c1708
comment:2 Changed 7 years ago by
 Commit changed from 09276715c5826609a87d21ae0947b30f6e5c1708 to f169eaa88c7b9dce933cfc90ae160dfaaf24aead
Branch pushed to git repo; I updated commit sha1. New commits:
f169eaa  Missing commit to fix asm files for Cygwin64.

comment:3 Changed 7 years ago by
 Commit changed from f169eaa88c7b9dce933cfc90ae160dfaaf24aead to 02866244b8b7ec0d9abb478ff9ba4a7a8b39cbed
Branch pushed to git repo; I updated commit sha1. New commits:
0286624  Prevent MPIR spkginstall script to force 32 bit on Cygwin*.

comment:4 Changed 7 years ago by
 Status changed from new to needs_review
comment:5 Changed 7 years ago by
I forgot to mention this here, but I was able to install MPIR on Cygwin64. Yet with #14648 failing on my other machines, the positive review will have to wait until that's done.
comment:6 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:7 Changed 7 years ago by
And MPIR 2.7 is on the way (which hopefully includes all fixes necessary, except those to spkginstall
of course).
comment:8 Changed 7 years ago by
yes indeed...
comment:9 followup: ↓ 12 Changed 7 years ago by
#15015 should supercede this ticket.
comment:10 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:11 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:12 in reply to: ↑ 9 Changed 7 years ago by
 Milestone changed from sage6.4 to sageduplicate/invalid/wontfix
#15015 should supercede this ticket.
So, this ticket should be closed now?
comment:13 Changed 7 years ago by
I'd say we shoudl wait for MPIR 2.7.0 to be released and #15015 to be merged.
comment:14 Changed 6 years ago by
 Resolution set to duplicate
 Reviewers set to Volker Braun
 Status changed from needs_review to closed
New commits:
Let MPIR build without C++ support on Cygwin.
Merge remotetracking branch 'trac/u/jpflori/ticket/15365' into ticket/14648
Update config.(guesssub) files to recognize Cygwin64.
Let MPIR build correctly on Cygwin64.