Opened 6 years ago

Closed 5 years ago

#15649 closed enhancement (fixed)

Modify Cygwin rebasing scripts to take cython compiled modules into account only once.

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.4
Component: porting: Cygwin Keywords: cygwin rebase
Cc: kcrisman, dimpase, tscrim, vbraun Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: dd55337 (Commits) Commit: dd55337ee2544cbdd6980010455d0840e2af80ea
Dependencies: Stopgaps:

Description

Currently when Sage is built, every dll produced from cython module is present twice in SAGE_ROOT (the exact location depends on hg or git version). See https://groups.google.com/d/msg/sage-devel/zlyuxWIcERQ/cLPRt2nufr4J

On cygwin, this completely pollutes the address space as only one of this two files is actually needed at runtime (not the on in build/lib.cygwin.../) and may lead to fork failures.

Change History (6)

comment:1 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:2 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:3 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:4 Changed 5 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/15649
  • Cc vbraun added
  • Commit set to dd55337ee2544cbdd6980010455d0840e2af80ea
  • Status changed from new to needs_review

New commits:

dd55337Only take installed files (in local) when rebasing on Cygwin.

comment:5 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Sorry, I thought I had reviewed this. LGTM.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15649 to dd55337ee2544cbdd6980010455d0840e2af80ea
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.