Opened 9 years ago

Closed 8 years ago

#15649 closed enhancement (fixed)

Modify Cygwin rebasing scripts to take cython compiled modules into account only once.

Reported by: Jean-Pierre Flori Owned by:
Priority: major Milestone: sage-6.4
Component: porting: Cygwin Keywords: cygwin rebase
Cc: Karl-Dieter Crisman, Dima Pasechnik, Travis Scrimshaw, Volker Braun Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: dd55337 (Commits, GitHub, GitLab) Commit: dd55337ee2544cbdd6980010455d0840e2af80ea
Dependencies: Stopgaps:

Status badges

Description

Currently when Sage is built, every dll produced from cython module is present twice in SAGE_ROOT (the exact location depends on hg or git version). See https://groups.google.com/d/msg/sage-devel/zlyuxWIcERQ/cLPRt2nufr4J

On cygwin, this completely pollutes the address space as only one of this two files is actually needed at runtime (not the on in build/lib.cygwin.../) and may lead to fork failures.

Change History (6)

comment:1 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:2 Changed 8 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:3 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:4 Changed 8 years ago by Jean-Pierre Flori

Authors: Jean-Pierre Flori
Branch: u/jpflori/ticket/15649
Cc: Volker Braun added
Commit: dd55337ee2544cbdd6980010455d0840e2af80ea
Status: newneeds_review

New commits:

dd55337Only take installed files (in local) when rebasing on Cygwin.

comment:5 Changed 8 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Sorry, I thought I had reviewed this. LGTM.

comment:6 Changed 8 years ago by Volker Braun

Branch: u/jpflori/ticket/15649dd55337ee2544cbdd6980010455d0840e2af80ea
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.