Opened 8 years ago

Closed 8 years ago

#15646 closed defect (fixed)

Move monsky_washnitzer.py from elliptic_curves to hyperelliptic_curves

Reported by: kedlaya Owned by:
Priority: major Milestone: sage-6.3
Component: elliptic curves Keywords: Monsky-Washnitzer, elliptic curves, hyperelliptic curves
Cc: defeo Merged in:
Authors: Jean-Pierre Flori Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: ff70460 (Commits, GitHub, GitLab) Commit: ff70460d9b3da25aa3192e78ae0cc693fa8fa91c
Dependencies: #8305 Stopgaps:

Status badges

Description

The code for computing Frobenius matrices in sage/elliptic_curves/monsky_washnitzer.py applies to hyperelliptic curves, not just elliptic curves. As such, it should be relocated accordingly. (This ticket is an unresolved issue from #8305.)

Change History (13)

comment:1 Changed 8 years ago by jpflori

  • Branch set to u/jpflori/ticket/15646
  • Commit set to 37ad1367454e621e9806cfaa1ac0f83cbcd33671

Still needs work. For some reason I now get a few fftRep errors in the matrix folder (benchmark.py and matrix_modn_dense_template.pxi). Maybe soimething like #2843.

comment:2 Changed 8 years ago by git

  • Commit changed from 37ad1367454e621e9806cfaa1ac0f83cbcd33671 to 9c8780e0ef97ba2a15cd0e45e4294a16a9251820

Branch pushed to git repo; I updated commit sha1. New commits:

9c8780eMerge remote-tracking branch 'trac/develop' into ticket/15646

comment:3 Changed 8 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Status changed from new to needs_review

Seems ok now...

comment:4 Changed 8 years ago by jpflori

  • Cc defeo added

comment:5 Changed 8 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me.

comment:6 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 8 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15646 to 9c8780e0ef97ba2a15cd0e45e4294a16a9251820
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 8 years ago by vbraun

  • Commit 9c8780e0ef97ba2a15cd0e45e4294a16a9251820 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

Documentation doesn't build after a "make doc-clean". Without the cleaning it works due to cached data.

comment:9 Changed 8 years ago by jpflori

I've just merged trac/develop on my branch on gcc110 and make doc-clean and make and no problem. I'll give it another round of doc-clean and then distclean if I get no problems.

comment:10 Changed 8 years ago by jpflori

Everything is still fine even after a make distclean. May I have forgotten aother cache?

Oh, or you mean I have to modify the rst stuff?

comment:11 Changed 8 years ago by jpflori

My bad, after a distclean it errors out.

comment:12 Changed 8 years ago by jpflori

  • Branch changed from 9c8780e0ef97ba2a15cd0e45e4294a16a9251820 to u/jpflori/ticket/15646
  • Commit set to ff70460d9b3da25aa3192e78ae0cc693fa8fa91c

Should be happy now.


New commits:

798a23dMove monsky_washnitzer.py.
2b87b0aFix imports in schemes/elliptic_curves after monsky_washnitzer moved.
37ad136Update import path in schemes/hyperelliptic_curves folder.
9c8780eMerge remote-tracking branch 'trac/develop' into ticket/15646
1012203Merge remote-tracking branch 'trac/develop' into ticket/15646
ff70460Fix documentation after moving monsky_washnitzer.py.

comment:13 Changed 8 years ago by vbraun

  • Branch changed from u/jpflori/ticket/15646 to ff70460d9b3da25aa3192e78ae0cc693fa8fa91c
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.