Opened 8 years ago
Closed 2 years ago
#15645 closed defect (fixed)
Raise coverage of schemes/hyperelliptic_curves/monsky_washnitzer.py to 100%
Reported by:  kedlaya  Owned by:  

Priority:  major  Milestone:  sage9.0 
Component:  elliptic curves  Keywords:  MonskyWashnitzer, elliptic curves, hyperelliptic curves, sd87 
Cc:  Merged in:  
Authors:  Kiran Kedlaya  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  c3b9fb1 (Commits, GitHub, GitLab)  Commit:  c3b9fb17f8b526fc9cce5aa19f4fea59da2e18cc 
Dependencies:  Stopgaps: 
Description (last modified by )
Change History (10)
comment:1 Changed 8 years ago by
 Description modified (diff)
 Summary changed from Raise coverage of schemes/elliptic_curves/monsky_washnitzer.py to 100% to Raise coverage of schemes/hyperelliptic_curves/monsky_washnitzer.py to 100%
comment:2 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:3 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:4 Changed 5 years ago by
 Keywords sd87 added
comment:5 Changed 2 years ago by
 Branch set to u/kedlaya/raise_coverage_of_schemes_hyperelliptic_curves_monsky_washnitzer_py_to_100_
comment:6 Changed 2 years ago by
 Commit set to c9ce0a6feba6b06fc224c8b2712ee44202a237bd
 Milestone changed from sage6.4 to sage9.0
This has been lingering for far too long... I added doctests to raise the coverage to 100%, but it would also be worth a look from someone with a better grip on the formatting conventions for docstrings.
New commits:
c9ce0a6  Add missing doctests to monsky_washnitzer.py, coverage to 100%

comment:7 Changed 2 years ago by
 Status changed from new to needs_review
comment:8 Changed 2 years ago by
 Branch changed from u/kedlaya/raise_coverage_of_schemes_hyperelliptic_curves_monsky_washnitzer_py_to_100_ to public/ticket/15645
 Commit changed from c9ce0a6feba6b06fc224c8b2712ee44202a237bd to c3b9fb17f8b526fc9cce5aa19f4fea59da2e18cc
 Dependencies #7926, #8305 deleted
 Reviewers set to Frédéric Chapoton
I have made a few further changes. If you approve them, feel free to set to positive.
New commits:
c3b9fb1  more doc tuning for MonskyW

comment:9 Changed 2 years ago by
 Status changed from needs_review to positive_review
Looks good to me!
comment:10 Changed 2 years ago by
 Branch changed from public/ticket/15645 to c3b9fb17f8b526fc9cce5aa19f4fea59da2e18cc
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
After #15646, this has been moved to hyperelliptic_curves. Doc is still needed.