Opened 7 years ago

Closed 6 years ago

#15641 closed enhancement (fixed)

sage-fix-pkg-checksums: allow file arguments

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.2
Component: scripts Keywords:
Cc: robertwb, ohanar Merged in:
Authors: Jeroen Demeyer Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 25b0e43 (Commits) Commit: 25b0e4389bddbf08a068e2b99f4666c0ba09240d
Dependencies: Stopgaps:

Description

Instead of always fixing all checksums of files in $SAGE_ROOT/upstream/*.tar*, allow the tarballs to be specified via command-line arguments.

Also support the command sha1sum (which might be available when shasum is not).

Change History (11)

comment:1 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/15641
  • Created changed from 01/07/14 08:32:24 to 01/07/14 08:32:24
  • Modified changed from 01/07/14 08:32:24 to 01/07/14 08:32:24

comment:2 Changed 7 years ago by jdemeyer

  • Branch u/jdemeyer/ticket/15641 deleted
  • Cc robertwb ohanar added
  • Status changed from new to needs_review

comment:3 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/15641
  • Commit set to 25b0e4389bddbf08a068e2b99f4666c0ba09240d

New commits:

25b0e43Allow specifying files to be checksummed

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 follow-up: Changed 7 years ago by ncohen

  • Status changed from needs_review to needs_info

Looks good ! All I did not understand it

-            echo $tarball
+            echo >&2 $tarball

What is the meaning of this ?

Nathann

comment:6 in reply to: ↑ 5 Changed 6 years ago by rws

Replying to ncohen:

Looks good ! All I did not understand it

-            echo $tarball
+            echo >&2 $tarball

What is the meaning of this ?

It prints the content of $tarball to stderr instead of stdout.

comment:7 Changed 6 years ago by ncohen

O_o

Weird. Is that totally equivalent to echo $tarball >&2 ? I thought the redirection was always at the end of the line O_o

Nathann

comment:8 Changed 6 years ago by jdemeyer

The following are equivalent:

echo $tarball >&2
echo >&2 $tarball

For echo statements, I prefer the redirection in the beginning, since it allows nice looking

echo >&2 "Hello Nathann,"
echo >&2 "how are you doing today?"
echo >&2 "Bye!"

which looks better than

echo "Hello Nathann," >&2
echo "how are you doing today?" >&2
echo "Bye!" >&2

comment:9 Changed 6 years ago by jdemeyer

  • Status changed from needs_info to needs_review

comment:10 Changed 6 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Funny. Good to go then :-)

Nathann

comment:11 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/15641 to 25b0e4389bddbf08a068e2b99f4666c0ba09240d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.