Opened 6 years ago

Closed 5 years ago

#15630 closed defect (fixed)

Various Cython files using mpn_popcount need to be linked to gmp

Reported by: jpflori Owned by:
Priority: critical Milestone: sage-6.1
Component: porting: Cygwin Keywords: cygwin linking
Cc: kcrisman, dimpase, tscrim Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: u/jpflori/ticket/15630 (Commits) Commit: e296eb4374640dd44b261e88a3ae43254a8f0aec
Dependencies: Stopgaps:

Description (last modified by jpflori)

Surely since #13352, coding_theory/binary_code uses mpn_popcount and so needs to be linked to gmp. At least on Cygwin this needs to be done explicitely trhough module_list.py.

Same problem for graphs/convexity_properties and a few other files.

Change History (6)

comment:1 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/15630
  • Cc kcrisman dimpase tscrim added
  • Commit set to 17f15e1db54d2ee5861294cf1523e4dc28aab032
  • Status changed from new to needs_review

New commits:

17f15e1binary_code.pyx needs to be linked to gmp.

comment:2 Changed 6 years ago by jpflori

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from binary_code.pyx needs to be linked to gmp to Various Cython files using mpn_popcount need to be linked to gmp

Checking no others file need it.

comment:3 Changed 6 years ago by git

  • Commit changed from 17f15e1db54d2ee5861294cf1523e4dc28aab032 to e296eb4374640dd44b261e88a3ae43254a8f0aec

Branch pushed to git repo; I updated commit sha1. New commits:

e296eb4Various Cython files using mpn_popcount need to be linked to gmp.

comment:4 Changed 6 years ago by jpflori

  • Description modified (diff)
  • Status changed from needs_work to needs_review

Should be ok now.

comment:5 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

This gets me as close as I've ever been to building on Cygwin32 (down to bad linking with polybori).

comment:6 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.