Opened 7 years ago

Closed 7 years ago

#15624 closed enhancement (fixed)

Support "make -jN"

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.2
Component: build Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: u/pbruin/15624-parallel-make (Commits, GitHub, GitLab) Commit: 43b3cd6bcb924ae8291e8d456d7e7e2bf5604ed8
Dependencies: #15596, #15580 Stopgaps:

Status badges

Description (last modified by jdemeyer)

This should be supported by the top-level Makefile:

$ make -j4

The branch on this ticket implements this for sub-makes. For uses of $MAKE outside of make itself (like building the Sage documentation or Sage library), the value of -j given to make cannot be determined so this cannot work.

Change History (8)

comment:1 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/15624
  • Created changed from 01/03/14 07:31:01 to 01/03/14 07:31:01
  • Modified changed from 01/03/14 07:31:01 to 01/03/14 07:31:01

comment:2 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to edd3b144ee734b54efa2e5a5c55e8065928a8d60
  • Dependencies set to #15596, #15580
  • Description modified (diff)

New commits:

edd3b14Support top-level make -jN

comment:3 Changed 7 years ago by git

  • Commit changed from edd3b144ee734b54efa2e5a5c55e8065928a8d60 to 8e1dabdb31da8a11748b2a07c80e881a002923f7

Branch pushed to git repo; I updated commit sha1. This was a forced push. Recent commits:

8e1dabdSupport top-level make -jN
0255a2aAllow sage --sdist without building Sage
68ac77fMerge branch 'u/jdemeyer/ticket/15596' of git:// into ticket/15580
c7c0106sage-sdist: copy upstream tarballs using sage-spkg
143e5e4Don't use cp -p in sage-clone-source

comment:4 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:7 Changed 7 years ago by pbruin

  • Branch changed from u/jdemeyer/ticket/15624 to u/pbruin/15624-parallel-make
  • Commit changed from 8e1dabdb31da8a11748b2a07c80e881a002923f7 to 43b3cd6bcb924ae8291e8d456d7e7e2bf5604ed8
  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

I used this to test #15765 and it appears to work well. Just changing the branch because of a trivial merge conflict.

comment:8 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.