Opened 7 years ago

Closed 7 years ago

#15620 closed defect (fixed)

StandardError is not Python 3 compatible

Reported by: ohanar Owned by:
Priority: major Milestone: sage-6.2
Component: misc Keywords:
Cc: Merged in:
Authors: R. Andrew Ohana, Jeroen Demeyer Reviewers: Jeroen Demeyer, R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/ticket/15620 (Commits, GitHub, GitLab) Commit: c71e084ba22a82b92a26fcc790ac4596bba51f5f
Dependencies: Stopgaps:

Status badges

Description

The simple solution is to replace all usage of StandardError with Exception.

Change History (11)

comment:1 Changed 7 years ago by ohanar

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by jdemeyer

  • Status changed from needs_review to needs_work

In src/sage/combinat/free_module.py, replace 

except (Exception, StopIteration):

by 

except Exception:

comment:3 Changed 7 years ago by jdemeyer

Never mind, I'll do it.

comment:4 Changed 7 years ago by jdemeyer

  • Branch changed from u/ohanar/StandardError to u/jdemeyer/ticket/15620
  • Created changed from 01/02/14 15:57:38 to 01/02/14 15:57:38
  • Modified changed from 01/03/14 23:30:19 to 01/03/14 23:30:19

comment:5 Changed 7 years ago by jdemeyer

  • Commit changed from 3df72b29a82aa3ef4f966fc4fddaaa592ba39ba1 to ccd33ebb507f6f7442ce9288a87071b59094000f
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_work to needs_review

Additional commit needs review.

New commits:

​ccd33ebFix some catching of exceptions

comment:6 Changed 7 years ago by ohanar

  • Authors changed from R. Andrew Ohana to R. Andrew Ohana, Jeroen Demeyer
  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, R. Andrew Ohana
  • Status changed from needs_review to positive_review

Looks good to me.

comment:7 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:8 Changed 7 years ago by vbraun

merge failure, please fix

comment:9 Changed 7 years ago by git

  • Commit changed from ccd33ebb507f6f7442ce9288a87071b59094000f to 7942f28d3307fbb3f2c6dd76879538e3782d9de4
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​7942f28Merge remote-tracking branch 'origin/develop' into ticket/15620

comment:10 Changed 7 years ago by git

  • Commit changed from 7942f28d3307fbb3f2c6dd76879538e3782d9de4 to c71e084ba22a82b92a26fcc790ac4596bba51f5f

Branch pushed to git repo; I updated commit sha1. New commits:

​c71e084Replace two more "except StandardError:"

comment:11 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.