Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15617 closed defect (fixed)

Update ncurses to dev version 5.9-20131221

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.2
Component: packages: standard Keywords: spkg ncurses
Cc: vbraun, dimpase Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: u/jpflori/ticket/15617 (Commits) Commit: 45bb1958462a55cef417859e02b2d2ab2a8d05e3
Dependencies: Stopgaps:

Description (last modified by jpflori)

This dev release includes a (large) bunch of various fixes, inlcuding those needed for #15317 (Cygwin) and #15268 (Solaris).

Use (vanilla, only renamed and recompressed to get rid of the dash in the version number) tarball at:

Change History (8)

comment:1 Changed 7 years ago by jpflori

  • Branch set to u/jpflori/ticket/15617
  • Cc vbraun dimpase added
  • Commit set to 45bb1958462a55cef417859e02b2d2ab2a8d05e3
  • Description modified (diff)
  • Keywords spkg ncurses added
  • Status changed from new to needs_review

The code about no-cpp-precomp flag was modified and after a very quick look our patch should not be needed anymore on OS X. I did not check it was the case yet, but I'll quickly give it a shot on bsd.

New commits:

45bb195Update ncurses to dev version 5.9-20131221.

comment:2 Changed 7 years ago by jpflori

FYI, it built correctly on bsd So no reason to hold on.

comment:3 Changed 7 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

It works for me on cygwin (both 32 and 64). Since it built okay on BSD, I'm giving this a positive review.

Last edited 7 years ago by tscrim (previous) (diff)

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 7 years ago by vbraun

This fails on mark/skynet: Please open another ticket to fix or I'll have to back this branch out again.

comment:7 Changed 7 years ago by jpflori

I think I got it: once again XOPEN_SOURCE stuff is passed to g++ through CPPFLAGS. Not sure if the bug is upstream or from autotools.

comment:8 Changed 7 years ago by vbraun

Follow-up ticket is #15796

Note: See TracTickets for help on using tickets.