Opened 5 years ago

Closed 5 years ago

#15615 closed defect (fixed)

Put ATLAS archdef tarballs into patches/ARCHS and resync ATLAS-lib dir

Reported by: jpflori Owned by:
Priority: critical Milestone: sage-6.2
Component: packages: standard Keywords: atlas spkg archdef cygwin
Cc: vbraun, dimpase Merged in:
Authors: Jean-Pierre Flori Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: u/jpflori/ticket/15615 (Commits) Commit: d8da9895f0cadf8d6e7b136e7e7f90f3faaa6135
Dependencies: Stopgaps:

Description (last modified by jpflori)

Not sure why but it seems the tarballs we shipped did not make the git transition. The ATLAS-lib dir is also outdated. Please use the tarball at:

Change History (20)

comment:1 Changed 5 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/15615
  • Commit set to 0553986600f60ae49e146838058ecfeb1aaead18
  • Description modified (diff)
  • Status changed from new to needs_review

Ive take the opportunity to add an ARM archdef tarball as provided at http://math-atlas.sourceforge.net/errata.html#armhardfp


New commits:

0553986Reintroduce ATLAS archdefs tarballs.

comment:2 Changed 5 years ago by jpflori

  • Description modified (diff)
  • Keywords cygwin added
  • Priority changed from major to critical
  • Summary changed from Put ATLAS archdef tarballs into patches/ARCHS to Put ATLAS archdef tarballs into patches/ARCHS and resync ATLAS-lib dir

The ATLAS-lib issue is surely my bad as it is already wrong in the sage 5.13 tarball... This make ATLAS not so useful on Cygwin, whence the severity change.

comment:3 follow-up: Changed 5 years ago by vbraun

Since we have to make our own ATLAS tarball anyways to embed lapack, I would be in favor of putting the archdef tarballs in there as well. Even though they are small, they are still binary stuff that we should keep out of the repo if possible.

comment:4 Changed 5 years ago by git

  • Commit changed from 0553986600f60ae49e146838058ecfeb1aaead18 to 1154b0d4c1f157d12f0e31cc883edf79531fdb3e

Branch pushed to git repo; I updated commit sha1. New commits:

1154b0dUpdate ATLAS checksum.

comment:5 in reply to: ↑ 3 Changed 5 years ago by jpflori

Replying to vbraun:

Since we have to make our own ATLAS tarball anyways to embed lapack, I would be in favor of putting the archdef tarballs in there as well. Even though they are small, they are still binary stuff that we should keep out of the repo if possible.

Yes, we also have to generate the autotools project an d put it in. I'm not so found of not tracking and putting the archdefs tarballs into the ATLAS tarball as there is no easy way to generate them as for the autotools project, or getting them somewhere upstream as for the lapack tarball.

comment:6 Changed 5 years ago by vbraun

Putting them into our git repo doesn't make it easier to obtain the archdefs either, it jut puts binary crap into our repo. If anything, it makes it worse for non-Sage users to get the archdefs.

comment:7 Changed 5 years ago by jpflori

Ok, so let's just put them somewhere on sagemath...

comment:8 Changed 5 years ago by git

  • Commit changed from 1154b0d4c1f157d12f0e31cc883edf79531fdb3e to 46eae63d9c0b9b2334c10f835666d3497102f92b

Branch pushed to git repo; I updated commit sha1. New commits:

comment:9 Changed 5 years ago by jpflori

Ok, now the archef tarballs are within the "upstream" tarball. I've taken the opportunity to add a Solaris archdef tarball. I've slightly reworked the atlas related scripts. Please review.

comment:10 Changed 5 years ago by git

  • Commit changed from 46eae63d9c0b9b2334c10f835666d3497102f92b to e56945eaa9f1806e5d02f8d113667cd02f8f2183

Branch pushed to git repo; I updated commit sha1. New commits:

e56945eReintroduce ATLAS archdef tarballs.

comment:11 Changed 5 years ago by jpflori

comment:12 Changed 5 years ago by jpflori

This fails to build on Cygwin64 when SAGE_FAT_BINARY is set, and is easy to fix: just don't force isa extensions as the win64 abi is not the same as the amd64 one and asm code cannot be assembled...

comment:13 Changed 5 years ago by git

  • Commit changed from e56945eaa9f1806e5d02f8d113667cd02f8f2183 to 37720867865917fabacfef659430f871c06ab4b3

Branch pushed to git repo; I updated commit sha1. New commits:

3772086Disable ATLAS ISA extensions on Cygwin64.

comment:14 Changed 5 years ago by vbraun

Changing the tarball without the version (excluding the patchlevel) is not supported ATM, I think. We cache files in the upstream/ dir as package-versionwithoutpatchlevel.tar.gz, so this ticket would break builds for everybody who has the old tarball cached.

Either combine with an upstream version bump or wait until the build system can handle this case.

Apart from that, positive review ;-)

comment:15 Changed 5 years ago by git

  • Commit changed from 37720867865917fabacfef659430f871c06ab4b3 to f4f17d6de74b4df8267b74d37c0b1ce768a9fec6

Branch pushed to git repo; I updated commit sha1. New commits:

f4f17d6Change package version to properly take tarball changes into account.

comment:16 Changed 5 years ago by jpflori

  • Description modified (diff)

comment:17 Changed 5 years ago by git

  • Commit changed from f4f17d6de74b4df8267b74d37c0b1ce768a9fec6 to d8da9895f0cadf8d6e7b136e7e7f90f3faaa6135

Branch pushed to git repo; I updated commit sha1. New commits:

d8da989Merge remote-tracking branch 'trac/develop' into ticket/15615

comment:18 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:19 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun

comment:20 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.