Opened 7 years ago

Closed 7 years ago

#15604 closed enhancement (fixed)

pynac and polybori shouldn't be dependencies of csage

Reported by: ohanar Owned by:
Priority: major Milestone: sage-6.2
Component: c_lib Keywords:
Cc: Merged in:
Authors: R. Andrew Ohana Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: u/ohanar/fix_csage_deps (Commits) Commit: 144d006f9185299c4121eb94bd606ee1fb16d992
Dependencies: Stopgaps:

Description

The pb_wrap.h and ginac_wrap.h headers should really belong in the sage library, since csage doesn't include them.

Change History (4)

comment:1 Changed 7 years ago by ohanar

  • Authors set to R. Andrew Ohana
  • Branch set to u/ohanar/fix_csage_deps
  • Commit set to 144d006f9185299c4121eb94bd606ee1fb16d992
  • Status changed from new to needs_review

Like #15594, I did this to make testing python3 stuff easier.


New commits:

144d006csage: remove the psuedo-depedencies polybori and pynac

comment:2 Changed 7 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review
  • Summary changed from pynac and polybori are psuedo-dependencies of csage to pynac and polybori shouldn't be dependencies of csage

comment:3 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:4 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.