Opened 6 years ago

Closed 19 months ago

#15597 closed defect (fixed)

Quasi-shuffle product

Reported by: elixyre Owned by:
Priority: major Milestone: sage-8.2
Component: combinatorics Keywords: IMA coding sprint, CHAs
Cc: kdilks, tscrim, darij, zabrocki, alauve, amypang, saliola, delecroix, chapoton Merged in:
Authors: Travis Scrimshaw Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: 06fd19d (Commits) Commit: 06fd19d5ca4db85ac3e7887e2767ed0663dbe52d
Dependencies: #25018 Stopgaps:

Description (last modified by tscrim)

Quasi Shuffle product for iterable objects and associative product. We implement this by extending the shuffle product with overlap (which is moved into combinat/shuffle.py).

Change History (20)

comment:1 Changed 6 years ago by elixyre

  • Branch set to u/elixyre/ticket/15597
  • Created changed from 12/27/13 14:27:02 to 12/27/13 14:27:02
  • Modified changed from 12/27/13 14:27:02 to 12/27/13 14:27:02

comment:2 Changed 6 years ago by tscrim

  • Commit set to edab1894597a8fc658e4dfa119df165665779740

#14914 might be of interest.

EDIT - IDK why my comment set the commit...

Last edited 6 years ago by tscrim (previous) (diff)

comment:3 Changed 6 years ago by git

  • Commit changed from edab1894597a8fc658e4dfa119df165665779740 to c32fe000e19b99a0dde44c614c6576f7033fb6fe

Branch pushed to git repo; I updated commit sha1. New commits:

​c32fe00Ticket 15597: revise the iterator and append a test

comment:4 Changed 6 years ago by git

  • Commit changed from c32fe000e19b99a0dde44c614c6576f7033fb6fe to aa338f44d586a0040f7dde3e34a73276a224c6f0

Branch pushed to git repo; I updated commit sha1. New commits:

​aa338f4Ticket 15597: fix an extrem case: empty list with a special elem_constructor

comment:5 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 6 years ago by git

  • Commit changed from aa338f44d586a0040f7dde3e34a73276a224c6f0 to 4c7e51bde6084ee8d573ac05ea8c9d607b360ef9

Branch pushed to git repo; I updated commit sha1. New commits:

​ec2f9a3Merge branch 'qs/15597' into quasishuffle/15597
​9730233fast Shuffle product compatible with iterable objects (use linear extension)
​24c6551Merge branch 'shuffle/15595' into shufflee/15595
​66c0f3ftrac 15595: Shuffle more efficient + some documentation + doctest
​f728210Merge branch 'shufflee/15595' into quasishuffle/15597
​4c7e51bticket 15597: update documentation

comment:7 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:8 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:9 Changed 4 years ago by kdilks

  • Authors set to kdilks

comment:10 Changed 4 years ago by kdilks

  • Authors kdilks deleted
  • Cc kdilks added

comment:11 Changed 4 years ago by chapoton

+Missing doctests combinat/quasi_shuffle.py 4 / 6 = 66%

comment:12 Changed 20 months ago by tscrim

  • Authors set to Travis Scrimshaw
  • Branch changed from u/elixyre/ticket/15597 to public/combinat/extend_shuffle_product-15597
  • Cc tscrim darij zabrocki alauve amypang saliola delecroix chapoton added
  • Commit changed from 4c7e51bde6084ee8d573ac05ea8c9d607b360ef9 to 3fab3a30f9d2468f7ca423475c120089e9f09ce5
  • Description modified (diff)
  • Keywords IMA coding sprint CHAs added
  • Milestone changed from sage-6.4 to sage-8.2
  • Status changed from new to needs_review

I have decided to approach this by modifying the ShuffleProduct_overlapping instead of implementing a new class as Jean-Baptiste had done.

New commits:

​7d5f9c0Moving shuffle products with overlap to combinat/shuffle.py.
​3fab3a3Extending shuffle products with overlap to more general iterables.

comment:13 Changed 20 months ago by darij

"deprecation=987654"???

comment:14 Changed 20 months ago by darij

Why is there a zero parameter? I don't think it's ever needed in the definition of the overlapping shuffles.

comment:15 Changed 20 months ago by git

  • Commit changed from 3fab3a30f9d2468f7ca423475c120089e9f09ce5 to 41160ed47c3ba780196ec46300b181db0baef29d

Branch pushed to git repo; I updated commit sha1. New commits:

​a60d29aMerge branch 'public/combinat/extend_shuffle_product-15597' of trac.sagemath.org:sage into qs
​41160edgetting rid of zero

comment:16 Changed 20 months ago by git

  • Commit changed from 41160ed47c3ba780196ec46300b181db0baef29d to 99c91e7552fba045befdecde78025c9a935be365

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​99c91e7getting rid of zero

comment:17 Changed 20 months ago by darij

  • Reviewers set to Darij Grinberg
  • Status changed from needs_review to positive_review

LGTM. Positive review (this includes Travis reviewing my commit over my shoulder).

comment:18 Changed 20 months ago by git

  • Commit changed from 99c91e7552fba045befdecde78025c9a935be365 to 06fd19d5ca4db85ac3e7887e2767ed0663dbe52d
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​f75e10dif w1 is a word, return a word, else a list
​3f8f272added doc test, minor change for test of Composition, correct import
​06fd19dMerge branch 'public/25018/bug_in_shuffle' of git://trac.sagemath.org/sage into public/combinat/extend_shuffle_product-15597

comment:19 Changed 20 months ago by tscrim

  • Dependencies set to #25018
  • Status changed from needs_review to positive_review

Trivial rebase over #25018.

comment:20 Changed 19 months ago by vbraun

  • Branch changed from public/combinat/extend_shuffle_product-15597 to 06fd19d5ca4db85ac3e7887e2767ed0663dbe52d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.