Opened 8 years ago

Closed 4 years ago

#15584 closed enhancement (fixed)

Implement the BZ multisegment crystal model

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-8.0
Component: combinatorics Keywords: crystals, multisegments
Cc: sage-combinat, aschilling, bsalisbury1, andrew.mathas Merged in:
Authors: Travis Scrimshaw Reviewers: Ben Salisbury, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 071abec (Commits, GitHub, GitLab) Commit: 071abec9e2057a63a977c696d4bad1b77640d023
Dependencies: Stopgaps:

Status badges

Description (last modified by tscrim)

For type An(1), we implement the BZ multisegment model for B(\infty)

Change History (40)

comment:1 Changed 8 years ago by tscrim

  • Owner changed from (none) to sage-combinat

comment:2 Changed 8 years ago by tscrim

  • Status changed from new to needs_review

comment:3 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:4 Changed 8 years ago by git

  • Commit changed from 222fdc24f3ec6fb41ecc709320bc3e091b438b70 to 060035a8cff90a07f15d5778b41c5217f3e938c9

Branch pushed to git repo; I updated commit sha1. New commits:

63f103cMerge branch 'develop' into public/combinat/crystals/more_affine
4d76623Merge branch 'develop' into public/combinat/crystals/more_affine
e9cfeffMerge branch 'develop' into public/combinat/crystals/more_affine
245aee2Merge branch 'develop' into public/combinat/crystals/more_affine
88c364bMerge branch 'develop' into public/combinat/crystals/more_affine
4160498Merge branch 'develop' into public/combinat/crystals/more_affine
060035aMerge branch 'develop' into public/combinat/crystals/more_affine

comment:5 Changed 8 years ago by ncohen

(must be adapted to #15882)

Nathann

comment:6 Changed 7 years ago by git

  • Commit changed from 060035a8cff90a07f15d5778b41c5217f3e938c9 to 23c69dbfc883e77dea44a8788964cdc44431230b

Branch pushed to git repo; I updated commit sha1. New commits:

c21494dMerge branch 'public/combinat/crystals/more_affine' of trac.sagemath.org:sage into public/combinat/crystals/more_affine
23c69dbMoved to the catalog.

comment:7 Changed 7 years ago by tscrim

  • Dependencies set to #16172

comment:8 Changed 7 years ago by git

  • Commit changed from 23c69dbfc883e77dea44a8788964cdc44431230b to 0ebd4660001df7d027ac4362baa8311705133c59

Branch pushed to git repo; I updated commit sha1. New commits:

5cfd4e1Cleaning up repr methods.
0bf521fMerge branch 'public/combinat/crystals/fix_repr-16172' into public/combinat/crystals/more_affine
0ebd466Fixed extraenous period.

comment:9 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:10 Changed 7 years ago by rws

  • Status changed from needs_review to needs_work

patchbot:

sage -t --long src/sage/combinat/rigged_configurations/kr_tableaux.py  # 1 doctest failed
sage -t --long src/sage/combinat/crystals/affinization.py  # 1 doctest failed
sage -t --long src/sage/schemes/plane_conics/con_rational_field.py  # Timed out
long time: 7 seconds ## line 148 ##

Suggest to set "long" for the last one.

comment:11 Changed 7 years ago by git

  • Commit changed from 0ebd4660001df7d027ac4362baa8311705133c59 to 65bc2b0ab4f92d91815aae7574aa7e5122f528ec

Branch pushed to git repo; I updated commit sha1. New commits:

584c3e9Merge branch 'public/combinat/crystals/more_affine' of trac.sagemath.org:sage into public/combinat/crystals/more_affine
65bc2b0Fixed != and doctests.

comment:12 Changed 7 years ago by tscrim

This ticket has nothing to do with schemes and no bearing on that last doctest.

comment:13 Changed 7 years ago by tscrim

  • Status changed from needs_work to needs_review

comment:14 Changed 7 years ago by git

  • Commit changed from 65bc2b0ab4f92d91815aae7574aa7e5122f528ec to 255e43e8493b6aca96bf21b0c8a65641e62dc5f9

Branch pushed to git repo; I updated commit sha1. New commits:

255e43eMerge branch 'public/combinat/crystals/more_affine' of trac.sagemath.org:sage into public/combint/crystals/more_affine

comment:15 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:16 Changed 7 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Doesn't merge (note: I don't care about this ticket)

comment:17 Changed 6 years ago by git

  • Commit changed from 255e43e8493b6aca96bf21b0c8a65641e62dc5f9 to dd5ef40c2d2a9c5707947f362b617788cdd92a84

Branch pushed to git repo; I updated commit sha1. New commits:

dd5ef40Merge branch 'public/combinat/crystals/more_affine' of trac.sagemath.org:sage into public/combinat/crystals/more_affine

comment:18 Changed 6 years ago by git

  • Commit changed from dd5ef40c2d2a9c5707947f362b617788cdd92a84 to 207520d9f96761ad371912b4aa1c96ba50357880

Branch pushed to git repo; I updated commit sha1. New commits:

9aca074Merge branch 'public/combinat/crystals/more_affine' of trac.sagemath.org:sage into public/combinat/crystals/more_affine
ca18c5cAdding affinization crystal and fixing Kyoto path model weight.
207520dMerge branch 'public/crystals/kyoto_path_model_weight-18769' into public/combinat/crystals/more_affine

comment:19 Changed 6 years ago by tscrim

  • Dependencies changed from #16172 to #16172 #18769
  • Status changed from needs_work to needs_review

comment:20 Changed 6 years ago by bsalisbury1

  • Milestone changed from sage-6.4 to sage-6.8
  • Reviewers set to Ben Salisbury
  • Status changed from needs_review to needs_work

Hi Travis,

There are still some things that need to be changed with the multipartition model and the multisegment model. Some highlights:

  • The Kleschev multipartition model and the JMMO multipartition model are closely related; perhaps both should be on the same ticket. Moreover, the display of these partitions should include the residues in cells of the partitions so that the charge of the partition is clear to the user (though maybe you have added this already after we talked a while back).
  • There are two well-known crystal structures on multisegments, and they are related by the star-crystal operators. The convention being used should be clear and probably even the star-crystal operators should be added. In particular, see the 2009 paper by Jacon and Lecouvey in Pac. J. Math. It is my personal opinion that the notation and structure of that paper is the one that should be followed for the implementation, including changing the data structure of the multisegments to use dictionaries of the form {(interval) : coefficient}.

I vaguely remember there being some additional changes, too, but I can't be more specific until I have time to delve deeper into the patch.

Best, Ben

comment:21 Changed 5 years ago by git

  • Commit changed from 207520d9f96761ad371912b4aa1c96ba50357880 to 666be09ee97d38b74b6be020d1a8d22f5ac101d1

Branch pushed to git repo; I updated commit sha1. New commits:

666be09Merge branch 'public/combinat/crystals/more_affine' of trac.sagemath.org:sage into public/combinat/crystals/more_affine

comment:22 Changed 5 years ago by git

  • Commit changed from 666be09ee97d38b74b6be020d1a8d22f5ac101d1 to ae76e724013cd995fe3be3aeb86ebeeb5531c555

Branch pushed to git repo; I updated commit sha1. New commits:

ae76e72Fix from bad merge.

comment:23 Changed 5 years ago by tscrim

  • Description modified (diff)
  • Milestone changed from sage-6.8 to sage-7.2

comment:24 Changed 5 years ago by tscrim

  • Description modified (diff)
  • Keywords crystals multisegments added
  • Milestone changed from sage-7.2 to sage-7.3
  • Summary changed from Some more affine crystals to Implement the BZ multisegment crystal modelc

I have combined the Kleshchev partition crystal in with #20564.

comment:25 Changed 5 years ago by tscrim

  • Summary changed from Implement the BZ multisegment crystal modelc to Implement the BZ multisegment crystal model

comment:26 Changed 4 years ago by git

  • Commit changed from ae76e724013cd995fe3be3aeb86ebeeb5531c555 to fef2f34d6c90a893d7d0e0342d6b508a20e7a45a

Branch pushed to git repo; I updated commit sha1. New commits:

fef2f34Merge branch 'public/combinat/crystals/more_affine' in 8.0.b2

comment:27 Changed 4 years ago by chapoton

need to change the sort to use a sorting key

comment:28 Changed 4 years ago by tscrim

  • Branch changed from public/combinat/crystals/more_affine to public/crystals/BZ_multisegments-15584
  • Commit changed from fef2f34d6c90a893d7d0e0342d6b508a20e7a45a to c241ef9e9447d755518b94581d7bbc7b5daeeae5
  • Dependencies #16172 #18769 deleted
  • Milestone changed from sage-7.3 to sage-8.0
  • Status changed from needs_work to needs_review

Done. I also removed kleshchev.py as that is now done in #15508.


New commits:

c241ef9Removing Kleshchev crystal (now in #15508) and cmp.

comment:29 Changed 4 years ago by chapoton

typo here:

Crystal of Bernstien-Zelevinsky

comment:30 Changed 4 years ago by chapoton

  • Reviewers changed from Ben Salisbury to Ben Salisbury, Frédéric Chapoton

otherwise, looks good. Once corrected, you can set to positive if a patchbot comes back green.

comment:31 Changed 4 years ago by git

  • Commit changed from c241ef9e9447d755518b94581d7bbc7b5daeeae5 to a368e5c4e46643109b4a8662594da8d65c47ab48

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

e1a5ac6add combinat/module_list.rst to tracked files to merge develop branch
b0d0fceMerge branch 't/18769/public/crystals/kyoto_path_model_weight-18769' into t/15584/public/combinat/crystals/more_affine
c49aa39signature rule documentation added to multisegments
b4be238Affinization --> AffinizationOf in catalog.py
14fd6a4fixed merge error in combinat/module_list.rst
ea900a7doctests removed ... for now ...
8fe08e9Merge branch 'develop' into t/15584/public/combinat/crystals/more_affine
18c1b20Rebase
7ed2949merged with updates to description
a368e5cMerge branch 'public/combinat/crystals/more_affine' of git://trac.sagemath.org/sage into public/crystals/BZ_multisegments-15584

comment:32 Changed 4 years ago by tscrim

  • Status changed from needs_review to needs_work

Ben and I are doing a little bit more work on this right now.

comment:33 Changed 4 years ago by git

  • Commit changed from a368e5c4e46643109b4a8662594da8d65c47ab48 to cc87885202d9d71e1308f862b2b1ec126ab2a834

Branch pushed to git repo; I updated commit sha1. New commits:

cc87885Changing repr/latex formatting to use linear combinations.

comment:34 Changed 4 years ago by tscrim

  • Status changed from needs_work to needs_review

Ben, I've decided to keep the original data structure because it is easier to work with and less manipulations are needed to pass around the data (and maybe because I'm just lazy too). This is probably faster too because we don't have to sort on every crystal operator (and new objects should be relatively quick to sort because they started nearly sorted).

I've made a few small tweaks to Ben's expanded documentation, beyond changing the repr/latex to use linear combinations (this was the last big thing Ben wanted). So only my few changes left to check.

Last edited 4 years ago by tscrim (previous) (diff)

comment:35 Changed 4 years ago by git

  • Commit changed from cc87885202d9d71e1308f862b2b1ec126ab2a834 to aa69545229e8f7c57dc1e7ec6ee7a9450eaf962e

Branch pushed to git repo; I updated commit sha1. New commits:

aa69545added negative sign to weight function on multisegments and extended the weight lattice for generalized young walls in highest_weight_crystals

comment:36 Changed 4 years ago by bsalisbury1

The weight function was missing a negative sign and there was a doctest failure in highest_weight_crystals. Both are fixed now.

Thanks, Travis, for getting this finished!

comment:37 Changed 4 years ago by git

  • Commit changed from aa69545229e8f7c57dc1e7ec6ee7a9450eaf962e to 071abec9e2057a63a977c696d4bad1b77640d023

Branch pushed to git repo; I updated commit sha1. New commits:

071abecremoved B.S. from authorship, fixed date, and updated email

comment:38 Changed 4 years ago by bsalisbury1

  • Status changed from needs_review to positive_review

comment:39 Changed 4 years ago by tscrim

Thank you both for doing the review.

comment:40 Changed 4 years ago by vbraun

  • Branch changed from public/crystals/BZ_multisegments-15584 to 071abec9e2057a63a977c696d4bad1b77640d023
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.