Opened 7 years ago
Closed 7 years ago
#15582 closed enhancement (duplicate)
Update to Gap 4.7.2
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  group theory  Keywords:  
Cc:  Merged in:  
Authors:  Volker Braun  Reviewers:  Travis Scrimshaw 
Report Upstream:  Fixed upstream, but not in a stable release.  Work issues:  
Branch:  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
New tarballs:
 http://boxen.math.washington.edu/home/release/sage6.1.beta3/upstream/gap4.7.2.tar.bz2
 http://boxen.math.washington.edu/home/release/sage6.1.beta3/upstream/gap_packages4.7.2.tar.bz2
 http://boxen.math.washington.edu/home/release/sage6.1.beta3/upstream/database_gap4.7.2.tar.bz2
 http://boxen.math.washington.edu/home/release/sage6.1.beta3/upstream/libgap4.7.2.tar.gz
Change History (26)
comment:1 Changed 7 years ago by
 Branch set to u/vbraun/update_to_gap_4_7_2
comment:2 Changed 7 years ago by
 Commit set to 3472a854df051b57d1cb7e4934913f17f1fef820
 Component changed from PLEASE CHANGE to group theory
 Description modified (diff)
 Status changed from new to needs_review
 Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 7 years ago by
comment:4 Changed 7 years ago by
Yes: author does checksum.ini, packageversion.txt
No: changelog in SPKG.txt is deprecated
comment:5 Changed 7 years ago by
 Commit changed from 3472a854df051b57d1cb7e4934913f17f1fef820 to 32c38bd0795e6f43cf9e471e6da6f41032a07245
Branch pushed to git repo; I updated commit sha1. New commits:
32c38bd  udpate to libgap4.7.2

8cbcbe1  upstream merged Jeroens cflags patch

af627db  update to gap4.7.2

9124eac  Merge remotetracking branch 'trac/u/vbraun/gap4.6.5' into gap_4_7_2

e4ea669  fix typo in version number

4d03d78  checked in the build scripts for the database_gap spkg

358f159  provide a spkgcheck to run the libgap testsuite

e22921b  moved gap_packages to new build system, deleted braid package

3d38b69  updated gap & libgap to 4.5.6

comment:6 Changed 7 years ago by
 Branch changed from u/vbraun/update_to_gap_4_7_2 to public/ticket/15582
 Commit changed from 32c38bd0795e6f43cf9e471e6da6f41032a07245 to 20f5d3ae56780f96cb70476075f03b1e22d7dd2c
 Reviewers set to Travis Scrimshaw
I also had to update the checksum for the libgap spkg. If it works for you, then its a positive review.
New commits:
20f5d3a  Updated checksum for libgap spkg.

comment:7 Changed 7 years ago by
Looks like the generator ordering changed again for various gap objects.
comment:8 Changed 7 years ago by
 Commit changed from 20f5d3ae56780f96cb70476075f03b1e22d7dd2c to b89547724ad8d4ccaa53afa2c80e088e945ff537
comment:9 Changed 7 years ago by
 Commit changed from b89547724ad8d4ccaa53afa2c80e088e945ff537 to 3bb8bdbd91c70d807b417a4efde29778a04651bf
Branch pushed to git repo; I updated commit sha1. New commits:
3bb8bdb  also fix long doctests

comment:10 Changed 7 years ago by
Note that conjugacy classes of SymmetricGroup(8)
now need the table of marks (database_gap
), the bound was a little bit higher in previous versions. This is not too surprising since Gap rewrote their conjugacy class code. I've simplified examples to SymmetricGroup(7)
, going to 8 doesn't really test anything that 7 doesn't already cover.
comment:11 Changed 7 years ago by
 Status changed from needs_review to positive_review
I agree. Tests pass for me too, so positive review.
comment:12 Changed 7 years ago by
 Commit changed from 3bb8bdbd91c70d807b417a4efde29778a04651bf to 65342e6f93168119ab31016aef8a33d409d80eba
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
65342e6  Merge branch 'public/groups/fp_groups15145' into public/ticket/15582

d70bb87  Changed "(You will...output.)" line back.

5c56415  break bullet point first line

c6c4c46  Fixed not run doctests.

b25b159  Merge branch 'public/groups/fp_groups15145' of trac.sagemath.org:sage into public/groups/fp_groups15145

c2875d7  Fixed failing doctest.

3b89811  #15145: review patch.

787b67e  15145: add instructions to construct all groups of order 15 or less as fp groups

comment:13 Changed 7 years ago by
 Status changed from needs_review to positive_review
Resolved conflict with #15145
comment:14 Changed 7 years ago by
 Resolution set to fixed
 Status changed from positive_review to closed
comment:15 Changed 7 years ago by
On Slowaris the doc build fails with the amazingly useless backtrace
 Attaching gdb to process id 17081. GNU gdb (GDB) 7.6.2 Copyright (C) 2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "sparcsunsolaris2.10". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. [New process 17081] Retry #1: Retry #2: Retry #3: Retry #4: 0x7f6c6d10 in ?? () Stack backtrace  No symbol table info available. #1 0x7f66cfdc in ?? () No symbol table info available. Backtrace stopped: previous frame identical to this frame (corrupt stack?)
comment:16 Changed 7 years ago by
 Resolution fixed deleted
 Status changed from closed to new
comment:17 Changed 7 years ago by
 Report Upstream changed from N/A to Reported upstream. No feedback yet.
The segfault also occurs with vanilla gap4.7.2. Reported upstream at http://tracker.gapsystem.org/issues/461
comment:18 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:19 Changed 7 years ago by
 Commit changed from 65342e6f93168119ab31016aef8a33d409d80eba to f8021680e367f7f5706ac723ce1d7432be7a6979
comment:20 Changed 7 years ago by
 Commit changed from f8021680e367f7f5706ac723ce1d7432be7a6979 to a41153f1c42677c21ce4b15882cf35da4dbfde0d
Branch pushed to git repo; I updated commit sha1. New commits:
a41153f  apply sparc patch also to libgap

comment:21 Changed 7 years ago by
 Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
comment:22 Changed 7 years ago by
 Commit changed from a41153f1c42677c21ce4b15882cf35da4dbfde0d to 1dc5d9e1e633f7b689ac308c2e632e90d5020a95
Branch pushed to git repo; I updated commit sha1. New commits:
1dc5d9e  fix trivial doctest failure

comment:23 Changed 7 years ago by
 Milestone changed from sage6.2 to sageduplicate/invalid/wontfix
Obsoleted by #15873
comment:24 Changed 7 years ago by
 Status changed from new to needs_review
comment:25 Changed 7 years ago by
 Branch public/ticket/15582 deleted
 Commit 1dc5d9e1e633f7b689ac308c2e632e90d5020a95 deleted
 Status changed from needs_review to positive_review
comment:26 Changed 7 years ago by
 Resolution set to duplicate
 Status changed from positive_review to closed
Does the ticket author need to update the
checksum.ini
(via the script) andpackageversion.txt
(plus possibly add a changelog toSPKG.txt
) when doing the version bump, or will that be done by the release manager?