Change History (26)

comment:1 Changed 8 years ago by vbraun

  • Branch set to u/vbraun/update_to_gap_4_7_2

comment:2 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 3472a854df051b57d1cb7e4934913f17f1fef820
  • Component changed from PLEASE CHANGE to group theory
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

comment:3 Changed 8 years ago by tscrim

Does the ticket author need to update the checksum.ini (via the script) and package-version.txt (plus possibly add a changelog to SPKG.txt) when doing the version bump, or will that be done by the release manager?

Last edited 8 years ago by tscrim (previous) (diff)

comment:4 Changed 8 years ago by vbraun

Yes: author does checksum.ini, package-version.txt

No: changelog in SPKG.txt is deprecated

comment:5 Changed 8 years ago by git

  • Commit changed from 3472a854df051b57d1cb7e4934913f17f1fef820 to 32c38bd0795e6f43cf9e471e6da6f41032a07245

Branch pushed to git repo; I updated commit sha1. New commits:

32c38bdudpate to libgap-4.7.2
8cbcbe1upstream merged Jeroens cflags patch
af627dbupdate to gap-4.7.2
9124eacMerge remote-tracking branch 'trac/u/vbraun/gap-4.6.5' into gap_4_7_2
e4ea669fix typo in version number
4d03d78checked in the build scripts for the database_gap spkg
358f159provide a spkg-check to run the libgap testsuite
e22921bmoved gap_packages to new build system, deleted braid package
3d38b69updated gap & libgap to 4.5.6

comment:6 Changed 8 years ago by tscrim

  • Branch changed from u/vbraun/update_to_gap_4_7_2 to public/ticket/15582
  • Commit changed from 32c38bd0795e6f43cf9e471e6da6f41032a07245 to 20f5d3ae56780f96cb70476075f03b1e22d7dd2c
  • Reviewers set to Travis Scrimshaw

I also had to update the checksum for the libgap spkg. If it works for you, then its a positive review.


New commits:

20f5d3aUpdated checksum for libgap spkg.

comment:8 Changed 8 years ago by git

  • Commit changed from 20f5d3ae56780f96cb70476075f03b1e22d7dd2c to b89547724ad8d4ccaa53afa2c80e088e945ff537

Branch pushed to git repo; I updated commit sha1. New commits:

b895477fix doctests: different gap generator orders
9bb3e1aadd atlasrep to database_gap (dependency for tomlib)
efc340afix doctests in the gap interface

comment:9 Changed 8 years ago by git

  • Commit changed from b89547724ad8d4ccaa53afa2c80e088e945ff537 to 3bb8bdbd91c70d807b417a4efde29778a04651bf

Branch pushed to git repo; I updated commit sha1. New commits:

3bb8bdbalso fix long doctests

comment:10 Changed 8 years ago by vbraun

Note that conjugacy classes of SymmetricGroup(8) now need the table of marks (database_gap), the bound was a little bit higher in previous versions. This is not too surprising since Gap rewrote their conjugacy class code. I've simplified examples to SymmetricGroup(7), going to 8 doesn't really test anything that 7 doesn't already cover.

comment:11 Changed 8 years ago by tscrim

  • Status changed from needs_review to positive_review

I agree. Tests pass for me too, so positive review.

comment:12 Changed 8 years ago by git

  • Commit changed from 3bb8bdbd91c70d807b417a4efde29778a04651bf to 65342e6f93168119ab31016aef8a33d409d80eba
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

65342e6Merge branch 'public/groups/fp_groups-15145' into public/ticket/15582
d70bb87Changed "(You will...output.)" line back.
5c56415break bullet point first line
c6c4c46Fixed not run doctests.
b25b159Merge branch 'public/groups/fp_groups-15145' of trac.sagemath.org:sage into public/groups/fp_groups-15145
c2875d7Fixed failing doctest.
3b89811#15145: review patch.
787b67e15145: add instructions to construct all groups of order 15 or less as fp groups

comment:13 Changed 8 years ago by vbraun

  • Status changed from needs_review to positive_review

Resolved conflict with #15145

comment:14 Changed 8 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:15 Changed 8 years ago by vbraun

On Slowaris the doc build fails with the amazingly useless backtrace

------------------------------------------------------------------------
Attaching gdb to process id 17081.
GNU gdb (GDB) 7.6.2
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "sparc-sun-solaris2.10".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
[New process 17081]
Retry #1:
Retry #2:
Retry #3:
Retry #4:
0x7f6c6d10 in ?? ()

Stack backtrace
---------------
No symbol table info available.
#1  0x7f66cfdc in ?? ()
No symbol table info available.
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

comment:16 Changed 8 years ago by vbraun

  • Resolution fixed deleted
  • Status changed from closed to new

comment:17 Changed 8 years ago by vbraun

  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

The segfault also occurs with vanilla gap-4.7.2. Reported upstream at http://tracker.gap-system.org/issues/461

comment:18 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:19 Changed 8 years ago by git

  • Commit changed from 65342e6f93168119ab31016aef8a33d409d80eba to f8021680e367f7f5706ac723ce1d7432be7a6979

Branch pushed to git repo; I updated commit sha1. New commits:

05220a8Merge remote-tracking branch 'trac/develop' into t/15582/public/ticket/15582
a147b7fremove duplicated changelog
f802168add SPARC alignment fix

comment:20 Changed 8 years ago by git

  • Commit changed from f8021680e367f7f5706ac723ce1d7432be7a6979 to a41153f1c42677c21ce4b15882cf35da4dbfde0d

Branch pushed to git repo; I updated commit sha1. New commits:

a41153fapply sparc patch also to libgap

comment:21 Changed 8 years ago by vbraun

  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

comment:22 Changed 8 years ago by git

  • Commit changed from a41153f1c42677c21ce4b15882cf35da4dbfde0d to 1dc5d9e1e633f7b689ac308c2e632e90d5020a95

Branch pushed to git repo; I updated commit sha1. New commits:

1dc5d9efix trivial doctest failure

comment:23 Changed 8 years ago by vbraun

  • Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix

Obsoleted by #15873

comment:24 Changed 8 years ago by vbraun

  • Status changed from new to needs_review

comment:25 Changed 8 years ago by tscrim

  • Branch public/ticket/15582 deleted
  • Commit 1dc5d9e1e633f7b689ac308c2e632e90d5020a95 deleted
  • Status changed from needs_review to positive_review

comment:26 Changed 8 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.