Opened 6 years ago

Closed 6 years ago

#15581 closed defect (fixed)

Shorter long tests for KR tableaux and rigged configruations.

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-6.1
Component: documentation Keywords: long tests
Cc: sage-combinat, aschilling, vbraun Merged in:
Authors: Travis Scrimshaw Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: public/combinat/rigged_configurations/speedups (Commits) Commit: d585a4462991e322713b12bc3ec2199aa4a83d93
Dependencies: #13872 Stopgaps:

Description (last modified by tscrim)

As per this thread: https://groups.google.com/forum/?fromgroups=#!topic/sage-combinat-devel/WMk7H-J65qE

The technical reasoning:

In #13872, I implemented e0 and f0 operators for KR tableaux and rigged configurations by mapping to their corresponding KirillovReshetikhinCrystal element, then applying e0 and f0 (respecitvely) there, and then pulling back. Previously they just returned None. In _test_stembridge_local_axioms(), it checks to see that e(i) and e(j) are both not None, which now there is a longer check if that's true, and if so, then it must perform the Stembridge axioms check. This is why the tests now take significantly longer than before.

The proposed solution:

Make the crystals smaller.

Change History (3)

comment:1 Changed 6 years ago by tscrim

  • Description modified (diff)
  • Status changed from new to needs_review

I made the really long tests now on (much) smaller crystals. I also moved one example to a better spot.

comment:2 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

lgtm, thanks!

comment:3 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.