Rename Graph.trace_faces to Graph.faces

[ncohen]

Somebody asked on AskSage how to compute the faces of a graph. And well, one wouldn't think of looking for trace_faces, to let's rename it :-P

This ticket also renames (with a deprecated alias) the method check_embedding_validity and check_pos_validity to _check_embedding_validity and _check_pos_validity. These things are internal things and should stay internal.

Nathann

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​51571f7

trac #15551: Rename Graph.trace_faces to Graph.faces

[tscrim]

A few minor things:

• The alignment of the ``embedding`` input bullet-point is off by a space (lines 3729-3734).
• Instead of doctest:1: message could you change it to the more robust doctest:...: message?
• Could you use Return instead of Returns on line 3721?
• I believe the error messages should be formatted as ValueError("lower case with no period").

Otherwise looks good. Thanks.

[ncohen]

Helloooooooooooo ! I fixed all of those except the last one. I don't think that it is soooo dangerous, plus I often write (informative) exceptions messages with several sentences (in which case upper case and periods are needed), and I think it helps ^^;

Nathann

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​47339dd	trac #15551: Reviewer's comments
​c3b7aec	trac #15551: Rebase on 6.1.beta2

[tscrim]

I thought that there was some PEP on this...but I can't find it, so it's a consistency with python/personal preference. *shrugs*

Positive review. Thanks Nathann.

[ncohen]

There should be a PEP against PEP. Thaaaaanks for the review :-)

Gosh, these days Sage is the only place where stuff is actually happening, and where people actually work toward something O_o

Nathann