Opened 7 years ago

Closed 7 years ago

#15529 closed defect (fixed)

Maxima takes version information from git repo

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-6.0
Component: build Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: u/vbraun/maxima_git_version (Commits) Commit: 148fc5808c66d6d2a0eae8846de6d88fd332d5ff
Dependencies: Stopgaps:

Description

Maxima's configure.in checks if it is being run from a git repo, and if so then it uses git describe --dirty as maxima version.

Change History (7)

comment:1 Changed 7 years ago by ohanar

Maybe add export GIT_DIR="$(pwd)/.git" right before configuring maxima?

comment:2 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/maxima_git_version

comment:3 Changed 7 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 8f43b28072a4bec216bc9b4d3859330ed6c497c6
  • Status changed from new to needs_review

New commits:

8f43b28Disable Maximas version-from-git feature

comment:4 Changed 7 years ago by ohanar

Probably want to increment patch version, otherwise looks good.

comment:5 Changed 7 years ago by git

  • Commit changed from 8f43b28072a4bec216bc9b4d3859330ed6c497c6 to 148fc5808c66d6d2a0eae8846de6d88fd332d5ff

Branch pushed to git repo; I updated commit sha1. New commits:

148fc58bump patchlevel to trigger maxima recompilation

comment:6 Changed 7 years ago by vbraun

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to positive_review

Done

comment:7 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.