Opened 7 years ago
Closed 5 years ago
#15525 closed enhancement (fixed)
More partition parents and fixes to global options
Reported by:  tscrim  Owned by:  sagecombinat 

Priority:  major  Milestone:  sage6.10 
Component:  combinatorics  Keywords:  partitions, global options 
Cc:  sagecombinat, nthiery, andrew.mathas, kdilks  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Kevin Dilks 
Report Upstream:  N/A  Work issues:  
Branch:  1ec481d (Commits)  Commit:  1ec481d803e3fa7d8c3d0e4038f4c476a73c0fd0 
Dependencies:  Stopgaps: 
Description
Currently the following breaks:
sage: P = Partitions(5, max_length=4) sage: loads(dumps(P))
since PartitionOptions
does not pickle, hence the IntegerListsLex
, which takes it as an (optional) input, does not.
The proposed solution is twofold:
 Add a class for partitions that inherit from
IntegerListsLex
(or use it as an iterator).  Add a warning when using the
global_options
parameter that the resulting class might not pickle.
Here's also a discussion on sagecombinatdevel:
https://groups.google.com/forum/?fromgroups=#!topic/sagecombinatdevel/Hyak8ndRi4o
I'm also going to add parent classes for kregular partitions.
Change History (20)
comment:1 Changed 7 years ago by
 Branch set to public/combinat/partitions_constraints
comment:2 Changed 7 years ago by
 Commit set to 7982d3ad9815b6313ac93880467aaf71ddb096ca
Branch pushed to git repo; I updated commit sha1. New commits:
7982d3a  Iniital fix and added regular partitions. 
comment:3 Changed 7 years ago by
 Branch changed from public/combinat/partitions_constraints to public/combinat/partitions_constraints15525
 Commit 7982d3ad9815b6313ac93880467aaf71ddb096ca deleted
comment:4 Changed 7 years ago by
 Commit set to 7982d3ad9815b6313ac93880467aaf71ddb096ca
Branch pushed to git repo; I updated commit sha1. New commits:
7982d3a  Iniital fix and added regular partitions. 
comment:5 Changed 7 years ago by
 Commit changed from 7982d3ad9815b6313ac93880467aaf71ddb096ca to 1adb368c00b4b8e1eb49186af47ee1e86dafd94f
comment:6 Changed 7 years ago by
 Status changed from new to needs_review
Okay, ready for consumption.
comment:7 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:8 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:9 Changed 6 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:10 Changed 6 years ago by
 Commit changed from 1adb368c00b4b8e1eb49186af47ee1e86dafd94f to c477d6cf7d5ac2143f700dc83123f7d2d8d919ac
Branch pushed to git repo; I updated commit sha1. New commits:
c477d6c  Merge branch 'public/combinat/partitions_constraints15525' of trac.sagemath.org:sage into public/combinat/partitions_constraints15525

comment:11 Changed 6 years ago by
 Commit changed from c477d6cf7d5ac2143f700dc83123f7d2d8d919ac to 03dcda9bd81cc42c2c61439ea11be485e15f6142
Branch pushed to git repo; I updated commit sha1. New commits:
03dcda9  Merge branch 'public/combinat/partitions_constraints15525' of trac.sagemath.org:sage into public/combinat/partitions_constraints15525

comment:12 Changed 5 years ago by
 Status changed from needs_review to needs_work
one failing doctest, see patchbot report
comment:13 Changed 5 years ago by
 Commit changed from 03dcda9bd81cc42c2c61439ea11be485e15f6142 to 0cc28a0202ba183faec750fa4e02083d1500e52d
comment:14 Changed 5 years ago by
 Cc kdilks added
 Status changed from needs_work to needs_review
comment:15 Changed 5 years ago by
 Milestone changed from sage6.4 to sage6.9
comment:16 Changed 5 years ago by
So far only noticing very minor issues.
 In the definition of being \ellregular, it should mention that m_i is the multiplicity of i in the partition. The first time I looked at this, I thought that m_i was maybe referring to the part sizes. In the source code you can just search for 'm_i' to see what it means, but in the HTML doc 'm_i' is always going to be Tex'd and harder to search for. Also,
character_polynomial()
doc used a_i to refer to the multiplicity of i in a permutation alpha, so maybe that should be changed to m_i to be consistent.  Does the code ever check that \ell is an integer, and preferably a nonnegative one?
comment:17 Changed 5 years ago by
 Commit changed from 0cc28a0202ba183faec750fa4e02083d1500e52d to 1ec481d803e3fa7d8c3d0e4038f4c476a73c0fd0
Branch pushed to git repo; I updated commit sha1. New commits:
1ec481d  Addressing Kevin's comments.

comment:18 Changed 5 years ago by
 Status changed from needs_review to positive_review
comment:19 Changed 5 years ago by
 Milestone changed from sage6.9 to sage6.10
 Reviewers set to Kevin Dilks
comment:20 Changed 5 years ago by
 Branch changed from public/combinat/partitions_constraints15525 to 1ec481d803e3fa7d8c3d0e4038f4c476a73c0fd0
 Resolution set to fixed
 Status changed from positive_review to closed
Here's the initial branch, still a little more work to be done.