Opened 7 years ago

Closed 7 years ago

#15520 closed defect (fixed)

remove isinteger option in delsarte_bound_hamming_space

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.1
Component: coding theory Keywords:
Cc: ppurka, pmueller Merged in:
Authors: Dmitrii Pasechnik Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: u/dimpase/ticket/15520 (Commits) Commit: 3f7ff3a96a680318c2a51f64910dee014396c5c4
Dependencies: Stopgaps:

Description (last modified by dimpase)

The isinteger in delsarte_bound_hamming_space makes no sense and should be removed. See ​http://permalink.gmane.org/gmane.comp.mathematics.sage.support/32894 for discussion

Check out the git branch to review.

Change History (6)

comment:1 Changed 7 years ago by ppurka

  • Cc pmueller added

I suggest also moving the keyword to the last place in the other function.

comment:2 Changed 7 years ago by dimpase

  • Branch set to u/dimpase/ticket/15520
  • Created changed from 12/15/13 15:02:21 to 12/15/13 15:02:21
  • Modified changed from 12/15/13 15:11:06 to 12/15/13 15:11:06

comment:3 Changed 7 years ago by git

  • Commit set to 3f7ff3a96a680318c2a51f64910dee014396c5c4

Branch pushed to git repo; I updated commit sha1. New commits:

​3f7ff3aalso changed the order of options, as requested in comment 1, and few other minor edits

comment:4 Changed 7 years ago by dimpase

  • Description modified (diff)
  • Status changed from new to needs_review

Fixed. Just in case, there are two commits in the branch, in chronological order 02dd0dcb216bc8a09c541d20bf37a7d3f54971c4 3f7ff3a96a680318c2a51f64910dee014396c5c4

I used sage --dev scripts.

comment:5 Changed 7 years ago by ppurka

  • Authors set to Dmitrii Pasechnik
  • Reviewers set to Punarbasu Purkayastha
  • Status changed from needs_review to positive_review

This looks good to me. Passes all tests in sage/coding and this is probably not used anywhere else either.

comment:6 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.