Deprecate the _boundary parameter
From the documentation (Graph.get_boundary?
or Graph.set_boundary?
) there is just no way to know what it does. So because of that probably nobody uses it. Or they guessed the purpose in some way I can't guess myself.
Then there are things like linear-time operations in functions like .delete_vertex
(noticed by #15278).
self._boundary = [v for v in self._boundary if v != vertex]
Sooooooooo unless somebody complains and is willing to write some documentation for this parameter, I think it'd be nice to deprecate then remove it.
Nathan
Change History (12)
Branch: |
→ u/ncohen/15494
|
Cc: |
SimonKing added
|
Status: |
new →
needs_review
|
Commit: |
→ 065181cb35e0232c21b4cd49affba9d5d0a5ece6
|
Commit: |
065181cb35e0232c21b4cd49affba9d5d0a5ece6 →
31a301ebfc045389237985e22732dbb5c229a4c4
|
Milestone: |
sage-6.1 →
sage-6.2
|
Status: |
needs_review →
needs_work
|
Commit: |
31a301ebfc045389237985e22732dbb5c229a4c4 →
8bb60b34d33a0db34c14713bc34d86420b159a31
|
Status: |
needs_work →
needs_review
|
Milestone: |
sage-6.2 →
sage-6.3
|
Reviewers: |
→ Frédéric Chapoton, Vincent Delecroix
|
Status: |
needs_review →
positive_review
|
Branch: |
u/ncohen/15494 →
8bb60b34d33a0db34c14713bc34d86420b159a31
|
Resolution: |
→ fixed
|
Status: |
positive_review →
closed
|
Branch pushed to git repo; I updated commit sha1. New commits: