Opened 5 years ago

Closed 5 years ago

#15494 closed defect (fixed)

Deprecate the _boundary parameter

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: graph theory Keywords:
Cc: SimonKing Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton, Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 8bb60b3 (Commits) Commit: 8bb60b34d33a0db34c14713bc34d86420b159a31
Dependencies: Stopgaps:

Description

From the documentation (Graph.get_boundary? or Graph.set_boundary?) there is just no way to know what it does. So because of that probably nobody uses it. Or they guessed the purpose in some way I can't guess myself.

Then there are things like linear-time operations in functions like .delete_vertex (noticed by #15278). 

self._boundary = [v for v in self._boundary if v != vertex]

Sooooooooo unless somebody complains and is willing to write some documentation for this parameter, I think it'd be nice to deprecate then remove it.

Nathan

Change History (12)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/15494
  • Cc SimonKing added
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 065181cb35e0232c21b4cd49affba9d5d0a5ece6

Branch pushed to git repo; I updated commit sha1. New commits:

​065181ctrac #15494: Deprecate the graph "boundary" parameter

comment:3 Changed 5 years ago by git

  • Commit changed from 065181cb35e0232c21b4cd49affba9d5d0a5ece6 to 31a301ebfc045389237985e22732dbb5c229a4c4

Branch pushed to git repo; I updated commit sha1. New commits:

​31a301etrac #15494: Deprecate the graph "boundary" parameter

comment:4 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 5 years ago by chapoton

Hello Nathann,

you should replace all the new doctest:1: (or any other number) by doctest:...: because the numbers will change all the time.

comment:6 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

comment:7 Changed 5 years ago by git

  • Commit changed from 31a301ebfc045389237985e22732dbb5c229a4c4 to 8bb60b34d33a0db34c14713bc34d86420b159a31

Branch pushed to git repo; I updated commit sha1. New commits:

​c1d7b62trac #15494: Rebase on 6.2.beta3
​8bb60b3trac #15494: replacing numbers with ...

comment:8 Changed 5 years ago by ncohen

  • Status changed from needs_work to needs_review

Done

Nathann

comment:9 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:10 Changed 5 years ago by vdelecroix

Hi,

It has been waiting long enough.

Vincent

comment:11 Changed 5 years ago by vdelecroix

  • Reviewers set to Frédéric Chapoton, Vincent Delecroix
  • Status changed from needs_review to positive_review

comment:12 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/15494 to 8bb60b34d33a0db34c14713bc34d86420b159a31
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.