Opened 5 years ago

Closed 5 years ago

#15490 closed defect (fixed)

improve documentation of projective dynatomic polynomial

Reported by: bhutz Owned by: w.wu
Priority: trivial Milestone: sage-6.2
Component: documentation Keywords:
Cc: Merged in:
Authors: Weixin Wu Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: baf61f1 (Commits) Commit: baf61f12b15b12bf7d782724d0f938feaff6d114
Dependencies: Stopgaps:

Description

There are two current issues. There is a typo: n instead of period.

Also, it would be nice to verify that the roots are actually giving preperiodic points of the correct period as a doctest.

Attachments (3)

trac#15490.patch (2.4 KB) - added by w.wu 5 years ago.
#15490: improve documentation of projective dynatomic polynomial
trac_15490_dynatomic_poly_documentation.patch (2.4 KB) - added by w.wu 5 years ago.
Trac 15490: improve documentation of projective dynatomic polynomial
trac_15490_dynatomic_poly_documentation.2.patch (2.2 KB) - added by w.wu 5 years ago.
Trac 15490: improve documentation of projective dynatomic polynomial

Download all attachments as: .zip

Change History (16)

Changed 5 years ago by w.wu

#15490: improve documentation of projective dynatomic polynomial

comment:1 Changed 5 years ago by bhutz

Needs a commit message and a more descriptive patch name.

Changed 5 years ago by w.wu

Trac 15490: improve documentation of projective dynatomic polynomial

comment:2 Changed 5 years ago by w.wu

  • Status changed from new to needs_review

comment:3 Changed 5 years ago by bhutz

  • Reviewers set to Ben Hutz
  • Status changed from needs_review to needs_work

Line 553-556 are duplicated and should be removed.

Line 539, 557 need a space around the =.

Since there are two attachments you should add an 'apply' block to the description.

Changed 5 years ago by w.wu

Trac 15490: improve documentation of projective dynatomic polynomial

comment:4 Changed 5 years ago by w.wu

  • Status changed from needs_work to needs_review

comment:5 Changed 5 years ago by bhutz

  • Branch set to u/bhutz/15490

trying to move this to git today...

comment:6 Changed 5 years ago by git

  • Commit set to 1cd006c33e71a665c2027b84b816bc49a9397dc8

Branch pushed to git repo; I updated commit sha1. New commits:

8237337Merging Sage-5.12.rc0 and sage-git fixes
07152d8Merge important bugfix for dev scripts
a1e5ad5Merge branch 'master' of ssh://trac.sagemath.org:2222/sage into trac_master
33bb808projective_product.patch
1cd006cImprove documentation of projective dynatomic polynomial

comment:7 Changed 5 years ago by git

  • Commit changed from 1cd006c33e71a665c2027b84b816bc49a9397dc8 to baf61f12b15b12bf7d782724d0f938feaff6d114

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

baf61f1Improve documentation of projective dynatomic polynomial

comment:8 Changed 5 years ago by bhutz

ok. I think I got it right the second time. These changes now look fine to me and pass on my system.

comment:9 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:10 Changed 5 years ago by w.wu

  • Status changed from needs_review to positive_review

I already checked everything, this ticket works on my system.

Last edited 5 years ago by w.wu (previous) (diff)

comment:11 Changed 5 years ago by vbraun

Please fill in author field

comment:12 Changed 5 years ago by bhutz

  • Authors set to Weixin Wu

comment:13 Changed 5 years ago by vbraun

  • Branch changed from u/bhutz/15490 to baf61f12b15b12bf7d782724d0f938feaff6d114
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.