Opened 5 years ago
Closed 5 years ago
#15490 closed defect (fixed)
improve documentation of projective dynatomic polynomial
Reported by:  bhutz  Owned by:  w.wu 

Priority:  trivial  Milestone:  sage6.2 
Component:  documentation  Keywords:  
Cc:  Merged in:  
Authors:  Weixin Wu  Reviewers:  Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  baf61f1 (Commits)  Commit:  baf61f12b15b12bf7d782724d0f938feaff6d114 
Dependencies:  Stopgaps: 
Description
There are two current issues. There is a typo: n
instead of period
.
Also, it would be nice to verify that the roots are actually giving preperiodic points of the correct period as a doctest.
Attachments (3)
Change History (16)
Changed 5 years ago by
comment:1 Changed 5 years ago by
Needs a commit message and a more descriptive patch name.
comment:2 Changed 5 years ago by
 Status changed from new to needs_review
comment:3 Changed 5 years ago by
 Reviewers set to Ben Hutz
 Status changed from needs_review to needs_work
Line 553556 are duplicated and should be removed.
Line 539, 557 need a space around the =.
Since there are two attachments you should add an 'apply' block to the description.
comment:4 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:6 Changed 5 years ago by
 Commit set to 1cd006c33e71a665c2027b84b816bc49a9397dc8
Branch pushed to git repo; I updated commit sha1. New commits:
8237337  Merging Sage5.12.rc0 and sagegit fixes

07152d8  Merge important bugfix for dev scripts

a1e5ad5  Merge branch 'master' of ssh://trac.sagemath.org:2222/sage into trac_master

33bb808  projective_product.patch

1cd006c  Improve documentation of projective dynatomic polynomial

comment:7 Changed 5 years ago by
 Commit changed from 1cd006c33e71a665c2027b84b816bc49a9397dc8 to baf61f12b15b12bf7d782724d0f938feaff6d114
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
baf61f1  Improve documentation of projective dynatomic polynomial

comment:8 Changed 5 years ago by
ok. I think I got it right the second time. These changes now look fine to me and pass on my system.
comment:9 Changed 5 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:10 Changed 5 years ago by
 Status changed from needs_review to positive_review
I already checked everything, this ticket works on my system.
comment:11 Changed 5 years ago by
Please fill in author field
comment:12 Changed 5 years ago by
comment:13 Changed 5 years ago by
 Branch changed from u/bhutz/15490 to baf61f12b15b12bf7d782724d0f938feaff6d114
 Resolution set to fixed
 Status changed from positive_review to closed
#15490: improve documentation of projective dynatomic polynomial