Opened 6 years ago
Closed 6 years ago
#15489 closed defect (fixed)
deprecate the dim argument for MIPVariables
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.2 
Component:  linear programming  Keywords:  
Cc:  ppurka, kcrisman, dimpase  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  cb4e41b (Commits)  Commit:  cb4e41b02160c54a3a3a4a429f0cfd8f49cefc54 
Dependencies:  #15482  Stopgaps: 
Description
I implemented this "dim" argument so that my_variable[2][3]
would work, and before noticing that my_variable[2,3]
worked too, and actually better. Thus this useless code should be removed, and I was probably the only one to use it in the first place :)
Nathann
Change History (15)
comment:1 Changed 6 years ago by
 Branch set to u/ncohen/15489
 Cc dimpase added
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
 Commit set to 2156b3a9c0d84f38d92820925f88cb7647288b6c
Branch pushed to git repo; I updated commit sha1. New commits:
2156b3a  trac #15489: deprecate the dim argument for MIPVariables 
9a66631  trac #15482: Scream where I had not thought of screaming before 
b50d7af  trac #15482: addressing the reviewer's comments 
1f6c156  trac #15482: Say very loud that LP variables are positive by default 
comment:3 Changed 6 years ago by
 Commit changed from 2156b3a9c0d84f38d92820925f88cb7647288b6c to 8a901ae4508000a72c535cc91adb6001d64954bd
comment:4 Changed 6 years ago by
 Commit changed from 8a901ae4508000a72c535cc91adb6001d64954bd to eeb4e8c2e0bd5724682fb50c10fb37300918c470
comment:5 Changed 6 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:6 Changed 6 years ago by
 Commit changed from eeb4e8c2e0bd5724682fb50c10fb37300918c470 to 60806600947f8d9cecb0e9805a81e1ba7484f22c
Branch pushed to git repo; I updated commit sha1. New commits:
d2870e1  trac #15482: shortening a line

cd5bb43  trac #15482: positive > nonnegative

dd7bde8  trac #15482: a broken doctest

c8addd9  trac #15482: rebase on 5.13.rc0

076f85b  trac #15482: Rebase on 6.2.beta0

b87f1de  trac #15482: Rebase on 6.2.beta1

9a7657b  trac #15482: Broken doctest

6080660  trac #15489: Rebase on updated #15482

comment:7 Changed 6 years ago by
I'm reviewing this one now.
comment:8 Changed 6 years ago by
I am getting
[numerical] docstring of sage.numerical.mip.MixedIntegerLinearProgram.set_binary:27: WARNING: Literal block expected; none found.
and the docbuild bails out with OSError
at the same line. Not sure which line of mip.pyx
is causing the trouble...
comment:9 Changed 6 years ago by
 Status changed from needs_review to needs_work
comment:10 Changed 6 years ago by
 Commit changed from 60806600947f8d9cecb0e9805a81e1ba7484f22c to cb4e41b02160c54a3a3a4a429f0cfd8f49cefc54
comment:11 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:13 Changed 6 years ago by
Thaaaaaaaaaaaaaanks !!!
Nathann
comment:14 Changed 6 years ago by
 Reviewers set to Dima Pasechnik
comment:15 Changed 6 years ago by
 Branch changed from u/ncohen/15489 to cb4e41b02160c54a3a3a4a429f0cfd8f49cefc54
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Wow. I did not realise there were so many LP in Sage
O_o
Nathann