Remove deprecated code from combinat/

[ncohen]

Removes deprecated code from #12930 #13821 #6136 (4 years old) #13072 #9265 together with #8429 #12469 #6519.

Nathann

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​a8bd310	trac #15466: Remove deprecated code from combinat/
​5993eac	trac #15467: Partitions should check its input "a bit" more carefully

[andrew.mathas]

Hi Nathann, thanks for starting this (or should that be thaaaaaaaaaaaanks!:).

I found a few more depreciated [sic] functions to remove in the words subdirectory and I moved a few import statements of deprecation so that they are now immediately above the function call. This will help ensure that there are no stray deprecation import statements left when the corresponding soon-to-be-depreciated code is removed. Finally, I killed off some documentation for some functions that are removed by this patch.

If you are happy with my changes let's make this a positive review. I've bumped the version number to 6 since we're using git.

[ps I have checked all of the doctsts in sage/combinat. I do get a doctext failure in root_system/coxeter_group.py but I get the same failure in master, so I think it has nothing to do with this ticket.]

---

New commits:

​6639e75

A few more deprecations

[ncohen]

Yooooooooooo !!

Hi Nathann, thanks for starting this (or should that be thaaaaaaaaaaaanks!:).

Well I'm glad to receive your help with this ! :-D

I found a few more depreciated [sic] functions to remove in the words subdirectory and I moved a few import statements of deprecation so that they are now immediately above the function call. This will help ensure that there are no stray deprecation import statements left when the corresponding soon-to-be-depreciated code is removed.

GoodGoodGood? !

Finally, I killed off some documentation for some functions that are removed by this patch.

Argggg ! Nice job spotting that ;-)

By the way : these days I use the --warn-links flag when building the doc. It tells you whenever some links are made toward non-existent functions. I guess it will be useful to spot things like that in the future, when this --warn-links will be a default, though right now there are too many broken lins in Sage to make it the default :-)

If you are happy with my changes let's make this a positive review. I've bumped the version number to 6 since we're using git.

The tests passed while I was reading the patch. Good to go, thanks :-)

[ps I have checked all of the doctsts in sage/combinat. I do get a doctext failure in root_system/coxeter_group.py but I get the same failure in master, so I think it has nothing to do with this ticket.]

Hmmmmm.. I don't get this error. Though at some point Volker told me that I should run "make" again in Sage's directory to update the spkg which may have changed since. Do give it a try when you don't need to use Sage for a while (it will recompile a lot of things). I used to have a couple of broken doctests, and it solved it !

Thank you again, and positive review to this patch ! ;-)

Nathann

[vbraun]

sage -t src/sage/misc/cachefunc.pyx
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 534, in sage.misc.cachefunc.CachedFunction.__init__
Failed example:
    g.cache
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 722, in sage.misc.cachefunc.CachedFunction.__call__
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 761, in sage.misc.cachefunc.CachedFunction.get_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 802, in sage.misc.cachefunc.CachedFunction.set_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 805, in sage.misc.cachefunc.CachedFunction.set_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 17}
Got:
    {((5, 'default'), ()): 17}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 867, in sage.misc.cachefunc.CachedFunction.clear_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************

[tscrim]

Fixed the failing doctest.

---

New commits:

​34aa97a	Merge branch 'u/andrew.mathas/ticket/15466' of trac.sagemath.org:sage into u/tscrim/ticket/15466
​cd43d7b	Fixed failing doctests for #15466.

[andrew.mathas]

I didn't understand why this patch should affect cachefunc.pyx but the doc-tests causing the problems all call number_of_partitions. Part of this patch removes depreciated code in partition.py and, in particular, it changes the calling syntax by removing a depreciated argument of k=None. This both explains the errors above and says that the correct fix is simply to change the output of the doct-tests as the patch does. Hence, positive review.

Andrew

[vbraun]

conflict, please merge in latest beta

[git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​25488e8

Merge branch 'u/tscrim/ticket/15466' of trac.sagemath.org:sage into u/tscrim/ticket/15466

[tscrim]

Done.

[vbraun]

Documentation doesn't build

build/pipestatus "./sage --docbuild --no-pdf-links all html -j  2>&1" "tee -a logs/dochtml.log"
Setting permissions of DOT_SAGE directory so only you can read and write it.
Traceback (most recent call last):
  File "/Users/buildslave-sage/slave/sage_git/build/src/doc/common/builder.py", line 1465, in <module>
    import sage.all
  File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/all.py", line 133, in <module>
    from sage.combinat.all   import *
  File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/all.py", line 1, in <module>
    from combinat import bell_number, catalan_number, euler_number, fibonacci, \
ImportError: cannot import name combinations

[tscrim]

I'm unable to reproduce this. I ran sync-build, nuked my docbuild, and rebuilt the entire thing.

[vbraun]

Might be due to #9505, please wait until 6.2.beta3 is out and then merge that in.

[vbraun]

6.2.beta3 is out ;-)

[ncohen]

Done !

Nathann

---

New commits:

​b4f424b	trac #15466: Rebase on 6.2.beta3
​d5086d0	trac #15466: remove dead import

[tscrim]

Hmmm...strange... I didn't see those imports when looking at the branch before. *shrugs*

PS - Thanks Nathann.

[ncohen]

Yeah, I find it strange too.... And I don't see why they could have been added from another patch in the meantime O_o

Nathann