Opened 7 years ago

Closed 7 years ago

#15465 closed defect (fixed)

Allow using Sage without dev/git

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.0
Component: misc Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: u/vbraun/run_without_git (Commits) Commit: 24e5a7388f98b535ae84aa5753439e0128994473
Dependencies: #14482 Stopgaps:

Description (last modified by vbraun)

For binary builds / system-wide installs and perhaps tarballs we should not require the git repository. This ticket fixes two doctests for that use case.

That is, to remove the development functionality you can now

  • delete SAGE_SRC/sage/dev
  • delete SAGE_ROOT/.git

and all doctests still pass

Change History (11)

comment:1 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/run_without_git

comment:2 Changed 7 years ago by git

  • Commit set to 067dfc6b5c4b25a64d23c97b48eaa7ce279146b9

Branch pushed to git repo; I updated commit sha1. New commits:

067dfc6Relax the cmdline test of "sage -dev", it may be disabled
fa29095Merging latest dev scripts to avoid conflict in sage-dev
713737ffall back to doctesting all files if new files cannot be identified
946b5b4fix the commandline sage -dev script
2941308Use a DoctestSageDevWrapper? for the global dev object during doctests
6a512d6Explicitly specify the key type in ssh-keygen (requried for Sun SSH)
702d7afdo not suggest force push

comment:3 Changed 7 years ago by vbraun

  • Dependencies set to #14482
  • Status changed from new to needs_review

comment:4 Changed 7 years ago by git

  • Commit changed from 067dfc6b5c4b25a64d23c97b48eaa7ce279146b9 to 24e5a7388f98b535ae84aa5753439e0128994473

Branch pushed to git repo; I updated commit sha1. New commits:

24e5a73better to ask for forgiveness

comment:5 Changed 7 years ago by ohanar

Because of the lazy import of the dev object, asking for forgiveness won't work.

comment:6 Changed 7 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to needs_work

comment:7 Changed 7 years ago by ohanar

  • Milestone changed from sage-5.13 to sage-6.0

comment:8 Changed 7 years ago by vbraun

  • Description modified (diff)
  • Summary changed from Allow using Sage without git repository to Allow using Sage without dev/git

The idea is to delete the src/sage/dev directory if development is not possible (e.g. because of file permissions). Just not importing dev is not a solution as the dev doctests are still around (and will all fail).

comment:9 Changed 7 years ago by vbraun

  • Status changed from needs_work to needs_review

comment:10 Changed 7 years ago by ohanar

  • Status changed from needs_review to positive_review

ok, in that case, this seems fine

comment:11 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.