Opened 7 years ago

Closed 7 years ago

#15453 closed defect (fixed)

Wrap IML calls in sig_on()

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-5.13
Component: linear algebra Keywords:
Cc: malb Merged in: sage-5.13.beta5
Authors: Jeroen Demeyer Reviewers: Martin Albrecht
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13311 Stopgaps:

Status badges

Description (last modified by jdemeyer)

In devel/sage/sage/matrix/matrix_integer_dense.pyx, wrap IML calls in _solve_iml() in sig_on()/sig_off().

The patch also changes the exception type for non-square matrices from ArithmeticError to ValueError, since that's just a limitation of the implementation, it's not a mathematical obstruction.

Attachments (1)

15453_iml_sig_on.patch (4.4 KB) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by jdemeyer

  • Cc malb added
  • Dependencies set to #13311
  • Status changed from new to needs_review

Changed 7 years ago by jdemeyer

comment:2 Changed 7 years ago by malb

  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to needs_work

patch looks good and passes test. However, can you document the fact that you changed the exception in the ticket's description. After that, it's an automatic positive review.

comment:3 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_work to positive_review

comment:4 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.13.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.