Opened 5 years ago

Closed 5 years ago

#15435 closed enhancement (fixed)

WeylGroup and CoxeterGroup to groups.<tab>

Reported by: ncohen Owned by:
Priority: trivial Milestone: sage-6.1
Component: group theory Keywords:
Cc: vbraun, fhivert, nthiery, vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: u/ncohen/15435 (Commits) Commit: 52a76265a64fe5c091e7c56e859a28e8d1343a4c
Dependencies: #15369 Stopgaps:

Description (last modified by ncohen)

As the title says. Those groups were still missing. I also add a couple of doctests to be sure that the feature remains.

Nathann

Change History (8)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/15435
  • Description modified (diff)
  • Status changed from new to needs_review

Following Nicolas' will, those two groups will lie in "groups.misc", near BraidGroup.

Nathann

comment:2 Changed 5 years ago by git

  • Commit set to 69f28524404278a53c73218127bcc7014696eeeb

Branch pushed to git repo; I updated commit sha1. New commits:

69f2852trac #15435: WeylGroup? and CoxeterGroup? to groups.<tab>
488029ftrac #15435: depends on #15369
16d141cAlias groups.misc.AdditiveCyclic? to IntegerModRing?
c6bb227Depends on #15368
0ad88a6Additions to groups.misc : AdditiveAbelian?, Free, Braid, SemimonomialTransformation?
3d75bd3Move QuaternionMatrixGroupGF3 from groups.misc to groups.matrix
2a68051Add affine groups to groups.<tab>
017084fBroken link in groups catalog doc

comment:3 Changed 5 years ago by ncohen

I will rebase this thing in a second to clean the dependencies.

Nathann

comment:4 Changed 5 years ago by git

  • Commit changed from 69f28524404278a53c73218127bcc7014696eeeb to 52a76265a64fe5c091e7c56e859a28e8d1343a4c

Branch pushed to git repo; I updated commit sha1. New commits:

52a7626trac #15435: WeylGroup and CoxeterGroup to groups.<tab>
6c7e2f4trac #15369: Alias groups.misc.AdditiveCyclic to IntegerModRing

comment:5 Changed 5 years ago by ncohen

  • Priority changed from major to trivial

comment:6 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:7 Changed 5 years ago by ncohen

Thaaaaaaaaaaaaaaaaaaaaanks !!

Nathann

comment:8 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.