Opened 4 years ago
Closed 3 years ago
#15419 closed enhancement (fixed)
Add explicit documentation about ymin, ymax to Graphics.show
Reported by: | kcrisman | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | graphics | Keywords: | beginner |
Cc: | Merged in: | ||
Authors: | Sergey Bykov | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | 31afba1 (Commits) | Commit: | 31afba177332fd49e041243f70b3cbe30f0fa2e0 |
Dependencies: | Stopgaps: |
Description
This ask.sagemath question points out that although ymin
and ymax
appear at various points in the documentation (I'll point out here), they are not actually mentioned as arguments to show
! That should be fixed, since we are trying to be pretty comprehensive otherwise.
Among other things, the fact that you can overwrite these parameters, as in this question, should be addressed in a few places. While we're at it, we might as well add a specific example in the plot doc showing two graphs, one with and one without these parameters...
Change History (7)
comment:1 Changed 4 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:2 Changed 4 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:3 Changed 3 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:4 Changed 3 years ago by
- Branch set to u/captaintrunky/add_explicit_documentation_about_ymin__ymax_to_graphics_show
comment:5 Changed 3 years ago by
- Commit set to 31afba177332fd49e041243f70b3cbe30f0fa2e0
- Status changed from new to needs_review
comment:6 Changed 3 years ago by
- Reviewers set to David Coudert
- Status changed from needs_review to positive_review
Hello,
For me this patch clarifies the usage of xmin, xmax, etc.
David.
comment:7 Changed 3 years ago by
- Branch changed from u/captaintrunky/add_explicit_documentation_about_ymin__ymax_to_graphics_show to 31afba177332fd49e041243f70b3cbe30f0fa2e0
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Fixed docs about xmin, xmax, ymin and ymax.