Opened 6 years ago

Closed 4 years ago

#15412 closed defect (fixed)

Simplify cythonization of sage/combinat.

Reported by: robertwb Owned by:
Priority: major Milestone: sage-6.8
Component: build Keywords:
Cc: Merged in:
Authors: Robert Bradshaw, Jeroen Demeyer Reviewers: Nathann Cohen, Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 6e1038c (Commits) Commit: 6e1038ca291905f856edaf9c17f9f1116bef2f23
Dependencies: #17765 Stopgaps:

Description

Use new glob-style pattern.

Change History (18)

comment:1 Changed 6 years ago by robertwb

  • Branch set to u/robertwb/ticket/15412
  • Created changed from 11/13/13 09:19:20 to 11/13/13 09:19:20
  • Modified changed from 11/13/13 09:19:20 to 11/13/13 09:19:20

comment:2 Changed 6 years ago by robertwb

  • Commit set to 34e9e114a34cf7386126a924795a515262571e50
  • Status changed from new to needs_review

New commits:

34e9e11Simplify combinat cythonization.

comment:3 Changed 6 years ago by ncohen

Same here. No need of gmp in expnums ?

Nathann

comment:4 Changed 6 years ago by robertwb

See the change to sage/combinat/expnums.pyx

comment:5 Changed 6 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Right, stupid me. I may have had combinat_cython in mind but anyway after deleting the build/ directory, building all files again then passing all tests I saw no doctest problem that seems to be related. SOooooooooo well :-)

Nathann

comment:6 Changed 6 years ago by jdemeyer

  • Authors set to Robert Bradshaw
  • Milestone changed from sage-5.13 to sage-6.0

comment:7 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:8 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

comment:9 Changed 6 years ago by robertwb

  • Status changed from needs_work to needs_info

What exactly is the error?

comment:10 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:11 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:12 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:13 Changed 4 years ago by jdemeyer

  • Authors changed from Robert Bradshaw to Robert Bradshaw, Jeroen Demeyer
  • Component changed from combinatorics to build
  • Dependencies set to #17765
  • Milestone changed from sage-6.4 to sage-6.8

Rebooting this ticket on top of #17765.

comment:14 Changed 4 years ago by jdemeyer

  • Status changed from needs_info to needs_review

comment:15 Changed 4 years ago by jdemeyer

  • Branch changed from u/robertwb/ticket/15412 to u/jdemeyer/ticket/15412

comment:16 Changed 4 years ago by jdemeyer

  • Commit changed from 34e9e114a34cf7386126a924795a515262571e50 to 6e1038ca291905f856edaf9c17f9f1116bef2f23

Forgot to push...


New commits:

29df90cSimplify cythonization of sage/structure.
5d30cd6Merge tag '6.8.beta5' into t/17765/17765-simplify-structure
6e1038cSimplify cythonization of sage/combinat

comment:17 Changed 4 years ago by jpflori

  • Reviewers changed from Nathann Cohen to Nathann Cohen, Jean-Pierre Flori
  • Status changed from needs_review to positive_review

Looks god.

comment:18 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/15412 to 6e1038ca291905f856edaf9c17f9f1116bef2f23
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.