Opened 6 years ago
Closed 5 years ago
#15412 closed defect (fixed)
Simplify cythonization of sage/combinat.
Reported by: | robertwb | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.8 |
Component: | build | Keywords: | |
Cc: | Merged in: | ||
Authors: | Robert Bradshaw, Jeroen Demeyer | Reviewers: | Nathann Cohen, Jean-Pierre Flori |
Report Upstream: | N/A | Work issues: | |
Branch: | 6e1038c (Commits) | Commit: | 6e1038ca291905f856edaf9c17f9f1116bef2f23 |
Dependencies: | #17765 | Stopgaps: |
Description
Use new glob-style pattern.
Change History (18)
comment:1 Changed 6 years ago by
- Branch set to u/robertwb/ticket/15412
- Created changed from 11/13/13 09:19:20 to 11/13/13 09:19:20
- Modified changed from 11/13/13 09:19:20 to 11/13/13 09:19:20
comment:2 Changed 6 years ago by
- Commit set to 34e9e114a34cf7386126a924795a515262571e50
- Status changed from new to needs_review
comment:3 Changed 6 years ago by
Same here. No need of gmp in expnums ?
Nathann
comment:4 Changed 6 years ago by
See the change to sage/combinat/expnums.pyx
comment:5 Changed 6 years ago by
- Reviewers set to Nathann Cohen
- Status changed from needs_review to positive_review
Right, stupid me. I may have had combinat_cython
in mind but anyway after deleting the build/ directory, building all files again then passing all tests I saw no doctest problem that seems to be related. SOooooooooo well :-)
Nathann
comment:6 Changed 6 years ago by
- Milestone changed from sage-5.13 to sage-6.0
comment:7 Changed 6 years ago by
- Milestone changed from sage-6.0 to sage-6.1
comment:8 Changed 6 years ago by
- Status changed from positive_review to needs_work
Similar to #15410, but slightly different error in conway polynomials; http://build.sagemath.org/sage/builders/%20%20fast%20Volker%20Desktop%20%28Fedora%2019%20x86_64%29%20full/builds/6/steps/compile_1/logs/conway
comment:9 Changed 6 years ago by
- Status changed from needs_work to needs_info
What exactly is the error?
comment:10 Changed 6 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:11 Changed 6 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:12 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:13 Changed 5 years ago by
- Component changed from combinatorics to build
- Dependencies set to #17765
- Milestone changed from sage-6.4 to sage-6.8
Rebooting this ticket on top of #17765.
comment:14 Changed 5 years ago by
- Status changed from needs_info to needs_review
comment:15 Changed 5 years ago by
- Branch changed from u/robertwb/ticket/15412 to u/jdemeyer/ticket/15412
comment:16 Changed 5 years ago by
- Commit changed from 34e9e114a34cf7386126a924795a515262571e50 to 6e1038ca291905f856edaf9c17f9f1116bef2f23
comment:17 Changed 5 years ago by
- Reviewers changed from Nathann Cohen to Nathann Cohen, Jean-Pierre Flori
- Status changed from needs_review to positive_review
Looks god.
comment:18 Changed 5 years ago by
- Branch changed from u/jdemeyer/ticket/15412 to 6e1038ca291905f856edaf9c17f9f1116bef2f23
- Resolution set to fixed
- Status changed from positive_review to closed
New commits: