Opened 13 years ago

Closed 13 years ago

#1539 closed defect (fixed)

[with patch; positive review] bdist of sage should include devel/doc

Reported by: was Owned by: mabshoff
Priority: blocker Milestone: sage-3.1.2
Component: distribution Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

wstein: note-to-self devel/doc is missing from the bdist.
[08:33am] wstein: maybe it shouldn't be.
[08:33am] wstein: I don't know.
[08:33am] wstein: I think bdist should have it...
[08:33am] wstein: trac ticket

Attachments (1)

scripts-1539.patch (886 bytes) - added by was 13 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 13 years ago by was

  • Priority changed from major to blocker

#1708 duplicated this

Also, here is a comment from Kate Minola, which is the same problem. I've thus promoted this to a blocker:

For sage-2.10.1, if I compile from source and run
'make check' - all is fine.  If I then build a binary
distribution (using -bdist), and then inside the binary
distribution run 'make check' I get the following errors.

Kate

Testing SAGE tutorial
/home/kate/sage/sage-2.10.1-x86_64-Linux/dist/sage-2.10.1-x86_64-Linux/
local/bin/sage-maketest: line 18: cd: /home/kate/sage/sage-2.10.1-
x86_64-Linux/dist/sage-2.10.1-x86_64-Linux/devel/doc/tut: No such file
or directory
ERROR: File ./tut.tex is missing
exit code: 1

----------------------------------------------------------------------
The following tests failed:


       ./tut.tex
Total time for all tests: 0.0 seconds
Testing SAGE programming guide
/home/kate/sage/sage-2.10.1-x86_64-Linux/dist/sage-2.10.1-x86_64-Linux/
local/bin/sage-maketest: line 22: cd: /home/kate/sage/sage-2.10.1-
x86_64-Linux/dist/sage-2.10.1-x86_64-Linux/devel/doc/prog: No such
file or directory
ERROR: File ./prog.tex is missing
exit code: 1

----------------------------------------------------------------------
The following tests failed:


       ./prog.tex
Total time for all tests: 0.0 seconds
Testing SAGE constructions guide
/home/kate/sage/sage-2.10.1-x86_64-Linux/dist/sage-2.10.1-x86_64-Linux/
local/bin/sage-maketest: line 26: cd: /home/kate/sage/sage-2.10.1-
x86_64-Linux/dist/sage-2.10.1-x86_64-Linux/devel/doc/const: No such
file or directory
ERROR: File ./const.tex is missing
exit code: 1

----------------------------------------------------------------------
The following tests failed:


       ./const.tex
Total time for all tests: 0.0 seconds

Changed 13 years ago by was

comment:2 Changed 13 years ago by was

  • Summary changed from bdist of sage should include devel/doc to [with patch; needs review] bdist of sage should include devel/doc

comment:3 Changed 13 years ago by mabshoff

  • Summary changed from [with patch; needs review] bdist of sage should include devel/doc to [with patch; positive review] bdist of sage should include devel/doc

Patch is good. Positive review.

Cheers,

Michael

comment:4 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.2.alpha1

Note: See TracTickets for help on using tickets.