Opened 5 years ago

Closed 5 years ago

#15376 closed enhancement (fixed)

Projective Point global_height remove special case for ZZ

Reported by: paulfili Owned by: paulfili
Priority: minor Milestone: sage-5.13
Component: algebraic geometry Keywords: sage-days55
Cc: Merged in: sage-5.13.beta4
Authors: Paul Fili Reviewers: Adam Towsley
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #15373 Stopgaps:

Description

global_height in Projective Point needed to make a special case for computing the global height when defined over ZZ, as ZZ lacked global_height. global_height was implemented for ZZ in #15373, so this special case can be removed.

Attachments (1)

trac_15376_use_ZZ_global_height.patch (1.2 KB) - added by paulfili 5 years ago.
Removes special case for global height of ZZ in projective_point

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by paulfili

  • Component changed from PLEASE CHANGE to algebraic geometry
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by paulfili

  • Authors set to Paul Fili

comment:3 Changed 5 years ago by paulfili

  • Owner changed from (none) to paulfili

comment:4 Changed 5 years ago by atowsley

  • Status changed from needs_review to positive_review

It passed the doc test and the long test.

Functionality still works.

comment:5 Changed 5 years ago by atowsley

  • Reviewers set to Adam Towsley

Changed 5 years ago by paulfili

Removes special case for global height of ZZ in projective_point

comment:6 Changed 5 years ago by jdemeyer

  • Merged in set to sage-5.13.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.