Opened 6 years ago

Closed 6 years ago

#15368 closed defect (fixed)

Some cleanup in groups.<tab>

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.1
Component: group theory Keywords:
Cc: vbraun, fhivert, nthiery, vdelecroix, jhpalmieri, kcrisman Merged in:
Authors: Nathann Cohen Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: u/ncohen/15368 (Commits) Commit: 0ad88a693361ceee5c1035ec3b4292ced17f0f48
Dependencies: Stopgaps:

Description

Following the discussion at https://groups.google.com/d/msg/sage-devel/tyAxhqxk3ZI/SuBg2Ukwwj4J

I was about to say what this patch does, then noticed that it would naturally appear on the ticket as the commit messages of the new branch :-)

The reference manual page for groups looks like it could be reordered and made cleaner, but I know so few about groups that I am sure I would do it all wrong if I gave it a try ^^;

Nathann

Change History (7)

comment:1 Changed 6 years ago by ncohen

  • Branch set to u/ncohen/15368
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by git

  • Commit set to 0ad88a693361ceee5c1035ec3b4292ced17f0f48

Branch pushed to git repo; I updated commit sha1. New commits:

0ad88a6Additions to groups.misc : AdditiveAbelian?, Free, Braid, SemimonomialTransformation?
3d75bd3Move QuaternionMatrixGroupGF3 from groups.misc to groups.matrix
2a68051Add affine groups to groups.<tab>
017084fBroken link in groups catalog doc

comment:3 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 6 years ago by ncohen

Thaaaaaaaaaaaaanks !!!

comment:5 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.13 to sage-6.0

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:7 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.