Opened 9 years ago

Closed 7 years ago

#15355 closed defect (fixed)

representation of CIF-element plus SR-element

Reported by: Daniel Krenn Owned by:
Priority: major Milestone: sage-6.4
Component: symbolics Keywords: SR, CIF, representation, sd67, beginner
Cc: Merged in:
Authors: Daniel Krenn Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: c03f6bd (Commits, GitHub, GitLab) Commit: c03f6bd762293af1a1a6946bb2e395db98dfc9dc
Dependencies: Stopgaps:

Status badges

Description (last modified by Daniel Krenn)

We have 

sage: x + CIF(RIF(-2,2), 0)
x

and 

sage: x + CIF(RIF(-2,2), RIF(-2,2))
x

which are wrong representation strings. Anyhow, the result themselves are correct since, for example, we have 

sage: z = (x + CIF(RIF(-2,2),RIF(-2,2)))
sage: z - x
0.?e1 + 0.?e1*I

In contrast, the following things work: 

sage: x + RIF(-2,2)
x + 0.?e1
sage: x + CIF(RIF(3.14,3.15), RIF(3.14, 3.15))
x + 3.15? + 3.15?*I
sage: CIF(RIF(-2,2), RIF(-2,2))
0.?e1 + 0.?e1*I
sage: x + CIF(RIF(3.14,3.15), 0)
x + 3.15?

Change History (9)

comment:1 Changed 9 years ago by Daniel Krenn

Description: modified (diff)

comment:2 Changed 9 years ago by For batch modifications

Milestone: sage-6.1 → sage-6.2

comment:3 Changed 8 years ago by For batch modifications

Milestone: sage-6.2 → sage-6.3

comment:4 Changed 8 years ago by For batch modifications

Milestone: sage-6.3 → sage-6.4

comment:5 Changed 7 years ago by Daniel Krenn

Branch: → u/dkrenn/t/15355

comment:6 Changed 7 years ago by Daniel Krenn

Authors: → Daniel Krenn
Commit: → c03f6bd762293af1a1a6946bb2e395db98dfc9dc
Keywords: sd67 added
Status: new → needs_review

Seems to be fixed (tested in 6.6). Added doctest.

New commits:

​c03f6bdadding doctests to check that 15355 is fixed

comment:7 Changed 7 years ago by Daniel Krenn

Keywords: beginner added

comment:8 Changed 7 years ago by Ralf Stephan

Reviewers: → Ralf Stephan
Status: needs_review → positive_review

Is fine, thanks.

comment:9 Changed 7 years ago by Volker Braun

Branch: u/dkrenn/t/15355 → c03f6bd762293af1a1a6946bb2e395db98dfc9dc
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.