Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#15339 closed defect (fixed)

gf2x tuning process needs to execute update-thresholds which needs a manifest file on Cygwin

Reported by: Jean-Pierre Flori Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting: Cygwin Keywords: cygwin spkg gf2x
Cc: Karl-Dieter Crisman, Dima Pasechnik, Travis Scrimshaw Merged in:
Authors: Reviewers: Jean-Pierre Flori, Travis Scrimshaw
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jean-Pierre Flori)

This used to be true on Windows 7+ at least, same problem for any exe whose name contains patch/install/update...

As this one happens during gf2x building process and Windows is particularly picky about timestamps of the exe and the corresponding manifest file, this will not be completely trivial to fix. i.e. we have to patch gf2x build system (or convince them to change the exe name... I'll report there shortly).

Attachments (1)

gf2x-1.1.p1.log (95.8 KB) - added by Travis Scrimshaw 8 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 9 years ago by Jean-Pierre Flori

Cc: Karl-Dieter Crisman Travis Scrimshaw added
Dependencies: #15316
Keywords: cygwin spkg gf2x added

comment:2 Changed 9 years ago by Jean-Pierre Flori

Authors: Jean-Pierre Flori
Branch: u/jpflori/ticket/15339
Report Upstream: N/AReported upstream. No feedback yet.
Status: newneeds_review

comment:3 Changed 9 years ago by git

Commit: d0512bb672bbf7bfde03e0156e00396c8ec64669

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

a278bc9Let gf2x use --libdir and make SAGE_FAT_BINARY work.
2371b35Replace symlink in a more portable way.
0e322baLet gf2x tune on Cygwin64.
0086d4aMake generic build of gf2x smarter.
59925a5More fixes for gf2x generic build.
5159831Support SSE2 on x86_64 for gf2x.
ddee57eSimplify generic build of gf2x.
fdd7694Properly autoreconfed patches.
75888b1Document new gf2x patch.
1fb1afePrevent autotools to regenerate files.

comment:4 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:5 Changed 8 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:6 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:7 Changed 8 years ago by Jean-Pierre Flori

I suggest we just don't tune on Windows >= 7 till gf2x does something upstream.

comment:8 Changed 8 years ago by Jean-Pierre Flori

Or do nothing, my latest tests were fine and Windows 7 just let update-thresholds.sh be executed without ranting.

comment:9 Changed 8 years ago by Jean-Pierre Flori

@Travis: can you confirm that update-thresholds now executes without trouble (if your Windows version is >=7 and recent enough)?

comment:10 Changed 8 years ago by Travis Scrimshaw

I believe my gf2x built on cygwin32 (I'm running Win8), which is sufficient, right? I'll double-check later today.

Changed 8 years ago by Travis Scrimshaw

Attachment: gf2x-1.1.p1.log added

comment:11 Changed 8 years ago by Travis Scrimshaw

1.1.p1 built successfully for me and I've attached the log in case there is something in there you (or if you tell me, I) need to look for.

comment:12 Changed 8 years ago by Jean-Pierre Flori

Authors: Jean-Pierre Flori
Branch: u/jpflori/ticket/15339
Commit: d0512bb672bbf7bfde03e0156e00396c8ec64669
Dependencies: #15316
Description: modified (diff)
Milestone: sage-6.4sage-duplicate/invalid/wontfix
Reviewers: Jean-Pierre Flori, Travis Scrimshaw
Status: needs_reviewpositive_review

Everything is fine! You have a ./update-thresholds -o tuned_thresholds.h < tunetoom.res and no errors.

comment:13 Changed 8 years ago by Volker Braun

Resolution: fixed
Status: positive_reviewclosed

comment:14 Changed 8 years ago by Jean-Pierre Flori

Strange, it now fails for me on Windows 7 64 bits under Cygwin32, but is ok under Cygwin64... And I re checked Travis log and there was no problem even if he was under Windows ? 64 bits under Cygwin32 !!!

comment:15 Changed 8 years ago by Sebastien Gouezel

It also fails for me in exactly the same situation (windows 7 64 bits, works with cygwin64, fails with cygwin32). Compiling as administrator solves the problem, but it is not very serious...

comment:16 Changed 8 years ago by Jean-Pierre Flori

A more and less serious solution is to export SAGE_TUNE_GF2X=no, I'll let you guess what it does...

comment:17 Changed 8 years ago by Jean-Pierre Flori

You can also disable UAC on Windows.

Whatsoever, we should maybe try to craft a manifest file for update-threshold.exe.

comment:18 Changed 8 years ago by Jean-Pierre Flori

Follow up at #17861.

Note: See TracTickets for help on using tickets.