Opened 6 years ago

Closed 6 years ago

#15333 closed enhancement (fixed)

remove the imports of is_* from modules/all.py and structure/all.py

Reported by: chapoton Owned by:
Priority: major Milestone: sage-6.2
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 98a2153 (Commits) Commit: 98a2153ae36a6e1abf1f0fb337ec66421fcc11ca
Dependencies: Stopgaps:

Description (last modified by chapoton)

part of #14329, and sequel of #15076 and #15098

Attachments (1)

trac_15333_step1.patch (6.7 KB) - added by chapoton 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by chapoton

comment:1 Changed 6 years ago by chapoton

  • Description modified (diff)

comment:2 Changed 6 years ago by chapoton

  • Branch set to u/chapoton/15333
  • Commit set to 865ce707b5982db0135d2b6cd50e1761c54459cf

New commits:

865ce70trac #15333 remove import of is_* in modules/all.py

comment:3 Changed 6 years ago by chapoton

  • Summary changed from remove the imports of is_* from modules/all.py to remove the imports of is_* from modules/all.py and structure/all.py

comment:4 Changed 6 years ago by git

  • Commit changed from 865ce707b5982db0135d2b6cd50e1761c54459cf to 98a2153ae36a6e1abf1f0fb337ec66421fcc11ca

Branch pushed to git repo; I updated commit sha1. New commits:

98a2153trac #15333 remove global imports in structure/all.py

comment:5 Changed 6 years ago by chapoton

  • Status changed from new to needs_review

comment:6 Changed 6 years ago by chapoton

  • Authors set to Frédéric Chapoton

comment:7 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:8 Changed 6 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

(Tested with Volker's current develop branch.)

comment:9 Changed 6 years ago by vbraun

please fill in reviewer name

comment:10 Changed 6 years ago by chapoton

  • Reviewers set to Marc Mezzarobba

comment:11 Changed 6 years ago by vbraun

  • Branch changed from u/chapoton/15333 to 98a2153ae36a6e1abf1f0fb337ec66421fcc11ca
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.