Opened 9 years ago

Closed 9 years ago

#15333 closed enhancement (fixed)

remove the imports of is_* from modules/all.py and structure/all.py

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-6.2
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 98a2153 (Commits, GitHub, GitLab) Commit: 98a2153ae36a6e1abf1f0fb337ec66421fcc11ca
Dependencies: Stopgaps:

Status badges

Description (last modified by Frédéric Chapoton)

part of #14329, and sequel of #15076 and #15098

Attachments (1)

trac_15333_step1.patch (6.7 KB) - added by Frédéric Chapoton 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by Frédéric Chapoton

Attachment: trac_15333_step1.patch added

comment:1 Changed 9 years ago by Frédéric Chapoton

Description: modified (diff)

comment:2 Changed 9 years ago by Frédéric Chapoton

Branch: u/chapoton/15333
Commit: 865ce707b5982db0135d2b6cd50e1761c54459cf

New commits:

865ce70trac #15333 remove import of is_* in modules/all.py

comment:3 Changed 9 years ago by Frédéric Chapoton

Summary: remove the imports of is_* from modules/all.pyremove the imports of is_* from modules/all.py and structure/all.py

comment:4 Changed 9 years ago by git

Commit: 865ce707b5982db0135d2b6cd50e1761c54459cf98a2153ae36a6e1abf1f0fb337ec66421fcc11ca

Branch pushed to git repo; I updated commit sha1. New commits:

98a2153trac #15333 remove global imports in structure/all.py

comment:5 Changed 9 years ago by Frédéric Chapoton

Status: newneeds_review

comment:6 Changed 9 years ago by Frédéric Chapoton

Authors: Frédéric Chapoton

comment:7 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:8 Changed 9 years ago by Marc Mezzarobba

Status: needs_reviewpositive_review

(Tested with Volker's current develop branch.)

comment:9 Changed 9 years ago by Volker Braun

please fill in reviewer name

comment:10 Changed 9 years ago by Frédéric Chapoton

Reviewers: Marc Mezzarobba

comment:11 Changed 9 years ago by Volker Braun

Branch: u/chapoton/1533398a2153ae36a6e1abf1f0fb337ec66421fcc11ca
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.