Opened 8 years ago

Closed 8 years ago

#15330 closed defect (fixed)

Poset.is_chain is wrong

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.1
Component: combinatorics Keywords:
Cc: darij, sage-combinat, nthiery, fhivert Merged in:
Authors: Nathann Cohen Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: u/darij/ticket/15330 (Commits, GitHub, GitLab) Commit: fe1870146db03147df832855daf74ee3cac659eb
Dependencies: Stopgaps:

Status badges

Description (last modified by ncohen)

I will say nothing.

Nothing.

It may get messy otherwise.

Nathann

Change History (10)

comment:1 Changed 8 years ago by darij

Nice catch. If you want to edit hasse_diagram.py, you might also want to correct the docstring of closed_interval (though now that I'm thinking about it, why not make it an alias of interval? is the interval method supposed to take some keyword parameters determining if it's closed or open one day?) and the missing backquotes in the _rank_dict docstring (on its second line).

comment:2 Changed 8 years ago by ncohen

Honestly this code makes me sick .... Interval is so not optimized... O_O

Nathann

comment:3 Changed 8 years ago by ncohen

Okay, anyway it's 1am and I am still hand-washing my laundry. Let's fix what must be >_<

Nathann

comment:4 Changed 8 years ago by ncohen

  • Branch set to u/ncohen/15330
  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 8 years ago by git

  • Commit set to 2fc96d427d55f4e8fdba30df99b54b8fd3dc138b

Branch pushed to git repo; I updated commit sha1. New commits:

[changeset:2fc96d4]Poset.is_chain is wrong and other details

comment:6 Changed 8 years ago by darij

  • Branch changed from u/ncohen/15330 to u/darij/ticket/15330
  • Created changed from 10/26/13 21:59:19 to 10/26/13 21:59:19
  • Modified changed from 10/26/13 22:55:12 to 10/26/13 22:55:12

comment:7 Changed 8 years ago by darij

  • Commit changed from 2fc96d427d55f4e8fdba30df99b54b8fd3dc138b to fe1870146db03147df832855daf74ee3cac659eb

If you're fine with my trivial edits (yeah, first successful git commit and whatever), it's positive review. Thanks for catching this very interesting reinterpretation of the word "chain"!

New commits:

[changeset:fe18701]trac #15330: minor docstring edit
[changeset:84182b0]Merge branch 'master' into ticket/15330

comment:8 Changed 8 years ago by ncohen

  • Reviewers set to Darij Grinberg
  • Status changed from needs_review to positive_review

Wow ! So cool ! A new Sage-Git dev, and my first reviewer's patch on a git ticket. That's cool :-P

Good to go, then ! Whener these tickets will be able to ... go anywhere :-P

Nathann

comment:9 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:10 Changed 8 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.