Opened 3 years ago

Closed 3 years ago

#15329 closed defect (fixed)

Fix pushout of completed fields

Reported by: SimonKing Owned by:
Priority: major Milestone: sage-6.1
Component: coercion Keywords:
Cc: Merged in:
Authors: Simon King Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: u/SimonKing/ticket/15329 (Commits) Commit: 9d8e7374e1c356bd7d1f50cc1e3dc1bba12c5099
Dependencies: Stopgaps:

Description

The aim is to fix the following problem.

sage: from sage.categories.pushout import pushout
sage: pushout(Qp(7),RLF)
Traceback (most recent call last):
...
RuntimeError: maximum recursion depth exceeded while calling a Python object

This boils down to change how CompletionFunctor (which is a type of construction functors used both for RLF and Qp(7)) commutes with other construction functors. Currently, it commutes with the fraction field functor and with other completion functors. But in fact it is simply not true that construction functors commute.

Change History (4)

comment:1 Changed 3 years ago by SimonKing

  • Branch set to u/SimonKing/ticket/15329
  • Created changed from 10/26/13 21:09:08 to 10/26/13 21:09:08
  • Modified changed from 10/26/13 21:09:08 to 10/26/13 21:09:08

comment:2 Changed 3 years ago by SimonKing

  • Authors set to Simon King
  • Commit set to 9d8e7374e1c356bd7d1f50cc1e3dc1bba12c5099
  • Status changed from new to needs_review

New commits:

[changeset:9d8e737]Different completion functors must not commute, to fix pushout of completed fields

comment:3 Changed 3 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba
  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 3 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.