Opened 8 years ago

Closed 7 years ago

#15323 closed enhancement (duplicate)

Upgrade GCC 4.8 series spkg to 4.8.2

Reported by: jpflori Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Jean-Pierre Flori Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jpflori)

A straightforward replacement of the src dir (and cleaning up with spkg-src) seems enough. Note that:

New spkg at http://boxen.math.washington.edu/home/jpflori/spkg/gcc-4.8.2.spkg

It seems this is currently an experimental spkg, maybe it could be moved to optional?

Attachments (1)

gcc-4.8.2.diff (1.1 KB) - added by jpflori 8 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 8 years ago by vbraun

  • Authors set to Jean-Pierre Flori

Do you have a spkg url? ;-) Does it work on the git directory layout?

comment:2 Changed 8 years ago by jpflori

No url yet, just a dirty spkg.

What's the requirement for the git layout? That everything not in the "upstream" tarball (which can be stripped, include additional files) is tracked?

comment:3 Changed 8 years ago by vbraun

yes, see also the existing examples.

comment:4 Changed 8 years ago by jpflori

  • Description modified (diff)

It did not seem to me that the spkg needed special treatment for the git layout though I have no access to a git install these days so I might be wrong.

Use spkg at http://boxen.math.washington.edu/home/jpflori/spkg/gcc-4.8.2.spkg

Tested on Cygwin and Ubuntu.

Changed 8 years ago by jpflori

Spkg diff, for review only.

comment:5 Changed 8 years ago by jpflori

  • Status changed from new to needs_review

Even though I've set the permission right on the spkg on boxen, the link gives me a 403 error. Maybe some magic caching issue somewhere deep in the internet.

comment:6 Changed 8 years ago by jdemeyer

You forgot to change the version number in SPKG.txt.

The only reason it's experimental is because it hasn't been tested on many systems.

Version 0, edited 8 years ago by jdemeyer (next)

comment:7 Changed 8 years ago by jdemeyer

Also, I would pass --disable-werror everywhere (it can't hurt on other systems, right?)

comment:8 follow-up: Changed 8 years ago by jpflori

Passing --disable-werrror shouldn't hurt, but a priori it is only needed on Cygwin. So it could only let relevant (and unexpected) warnings pass unnoticed on other systems. I don't have a strong opinion about that though.

spkg update with correct version number.

comment:9 in reply to: ↑ 8 Changed 8 years ago by jdemeyer

Replying to jpflori:

I don't have a strong opinion about that though.

I have had bad experiences with -Werror in the past, where a perfectly fine program refused to compile because of a harmless warning. I believe that -Werror should never be used by default. It is useful for maintainers of a package to check their compilation, but only for this.

comment:10 Changed 8 years ago by jpflori

Let's pass it everywhere then.

Please don't download the spkg right now.

comment:11 Changed 8 years ago by jpflori

  • Status changed from needs_review to needs_work

Hum, looking backa t my virtual machine seems to indicate that --disable-werror is still broken anyway... Note that http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56057 was assessing the contrary. So I might need to include a more involved patch as I originally did for my personal use.

comment:12 Changed 8 years ago by jdemeyer

Too bad that #14460 still isn't fixed...

comment:13 Changed 8 years ago by jpflori

See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32193 as well as far as -Werror is concerned.

comment:14 Changed 8 years ago by jpflori

A fix as in #15366 should be included as well.

comment:15 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:16 Changed 7 years ago by jpflori

And GCC 4.9 is now released (though Sage does not build with it, #16208).

comment:17 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:18 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:19 Changed 7 years ago by jpflori

We should surely close this one as an upgrade to 4.9.x is planned at #17169.

comment:20 Changed 7 years ago by vbraun

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix

comment:21 Changed 7 years ago by jpflori

  • Status changed from needs_work to positive_review

Let's also close this one.

comment:22 Changed 7 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.