Opened 5 years ago
Closed 4 years ago
#15323 closed enhancement (duplicate)
Upgrade GCC 4.8 series spkg to 4.8.2
Reported by: | jpflori | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: optional | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jean-Pierre Flori | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
A straightforward replacement of the src dir (and cleaning up with spkg-src) seems enough. Note that:
- #14460 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56982) is not fixed
- it fails on Cygwin because libbacktrace passes -Werror which errors out as -fPIC is also passed but results in a warning (and so an error with -Werror) on Cygwin We need to configure it with --disable-werror, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56057 .
New spkg at http://boxen.math.washington.edu/home/jpflori/spkg/gcc-4.8.2.spkg
It seems this is currently an experimental spkg, maybe it could be moved to optional?
Attachments (1)
Change History (23)
comment:1 Changed 5 years ago by
comment:2 Changed 5 years ago by
No url yet, just a dirty spkg.
What's the requirement for the git layout? That everything not in the "upstream" tarball (which can be stripped, include additional files) is tracked?
comment:3 Changed 5 years ago by
yes, see also the existing examples.
comment:4 Changed 5 years ago by
- Description modified (diff)
It did not seem to me that the spkg needed special treatment for the git layout though I have no access to a git install these days so I might be wrong.
Use spkg at http://boxen.math.washington.edu/home/jpflori/spkg/gcc-4.8.2.spkg
Tested on Cygwin and Ubuntu.
comment:5 Changed 5 years ago by
- Status changed from new to needs_review
Even though I've set the permission right on the spkg on boxen, the link gives me a 403 error. Maybe some magic caching issue somewhere deep in the internet.
comment:6 Changed 5 years ago by
You forgot to change the version number in SPKG.txt
.
The only reason it's experimental is because it hasn't been tested on many systems and because the requirement of having a C++ compiler is an extra step compared to GCC-4.7.x.
comment:7 Changed 5 years ago by
Also, I would pass --disable-werror
everywhere (it can't hurt on other systems, right?)
comment:8 follow-up: ↓ 9 Changed 5 years ago by
Passing --disable-werrror shouldn't hurt, but a priori it is only needed on Cygwin. So it could only let relevant (and unexpected) warnings pass unnoticed on other systems. I don't have a strong opinion about that though.
spkg update with correct version number.
comment:9 in reply to: ↑ 8 Changed 5 years ago by
Replying to jpflori:
I don't have a strong opinion about that though.
I have had bad experiences with -Werror
in the past, where a perfectly fine program refused to compile because of a harmless warning. I believe that -Werror
should never be used by default. It is useful for maintainers of a package to check their compilation, but only for this.
comment:10 Changed 5 years ago by
Let's pass it everywhere then.
Please don't download the spkg right now.
comment:11 Changed 5 years ago by
- Status changed from needs_review to needs_work
Hum, looking backa t my virtual machine seems to indicate that --disable-werror is still broken anyway... Note that http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56057 was assessing the contrary. So I might need to include a more involved patch as I originally did for my personal use.
comment:12 Changed 5 years ago by
Too bad that #14460 still isn't fixed...
comment:13 Changed 5 years ago by
See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32193 as well as far as -Werror is concerned.
comment:14 Changed 5 years ago by
A fix as in #15366 should be included as well.
comment:15 Changed 5 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:16 Changed 5 years ago by
And GCC 4.9 is now released (though Sage does not build with it, #16208).
comment:17 Changed 5 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:18 Changed 5 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:19 Changed 4 years ago by
We should surely close this one as an upgrade to 4.9.x is planned at #17169.
comment:20 Changed 4 years ago by
- Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
comment:21 Changed 4 years ago by
- Status changed from needs_work to positive_review
Let's also close this one.
comment:22 Changed 4 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Do you have a spkg url? ;-) Does it work on the git directory layout?