Opened 6 years ago

Closed 6 years ago

#15292 closed defect (fixed)

matroids.Uniform(r,r) returns wrong matroid

Reported by: Stefan Owned by:
Priority: minor Milestone: sage-6.1
Component: matroid theory Keywords:
Cc: Merged in:
Authors: Rudi Pendavingh Reviewers: Stefan van Zwam
Report Upstream: N/A Work issues:
Branch: u/Rudi/ticket/15292 (Commits) Commit: a8a28c71bcf525845acd73620839e86549e4b2f2
Dependencies: Stopgaps:

Description

The following is wrong:

sage: M = matroids.Uniform(4,4)
sage: len(M.circuit_closures())
1
sage: N = matroids.Uniform(4,5).delete(4)
sage: len(N.circuit_closures())
0
sage: N.is_isomorphic(M)
True

Change History (5)

comment:1 Changed 6 years ago by Rudi

  • Branch set to u/Rudi/ticket/15292
  • Created changed from 10/16/13 16:41:36 to 10/16/13 16:41:36
  • Modified changed from 10/16/13 16:41:36 to 10/16/13 16:41:36

comment:2 Changed 6 years ago by Rudi

  • Authors set to Rudi Pendavingh
  • Commit set to a8a28c71bcf525845acd73620839e86549e4b2f2
  • Status changed from new to needs_review

New commits:

a8a28c7Fixed bug in uniform matroid.

comment:3 Changed 6 years ago by Stefan

  • Status changed from needs_review to positive_review

The code looks solid to me, a simple bug fix. Positive review!

comment:4 Changed 6 years ago by vbraun

  • Reviewers set to Stefan van Zwam

Please fill in reviewer name next time...

comment:5 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.