Opened 6 years ago

Closed 5 years ago

#15287 closed enhancement (fixed)

Orthogonal Arrays

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.2
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Nathann Cohen Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 849598e (Commits) Commit: 849598e3802c167a7247d1a73181516556607950
Dependencies: #15286 Stopgaps:

Description

This ticket creates a file combinat/design/orthogonal_arrays.py and adds some constructions of orthogonal arrays and transversal design (a specific case) found in Douglas Stinson's book "Combinatorial Designs: Constructions and Analysis".

Change History (10)

comment:1 Changed 6 years ago by ncohen

  • Branch set to u/ncohen/15287
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by git

  • Commit set to 7c1b6513278bd173f5b54e5ac9b33e325bb48939

Branch pushed to git repo; I updated commit sha1. New commits:

[changeset:7c1b651]Orthogonal arrays
[changeset:d93abcd]Latin Squares
[changeset:2ec76c7]Bug in AffineGeometryDesign?
[changeset:cf71d58]Rebase on 5.13.beta0
[changeset:9fcfb13]Rename the method from ProjectivePlaneDesign? to DesarguesianProjectivePlaneDesign?
[changeset:363badb]trac 15107 -- reviewer's comments
[changeset:ee6d412]Projective Plane designs constructor

comment:3 Changed 6 years ago by git

  • Commit changed from 7c1b6513278bd173f5b54e5ac9b33e325bb48939 to e32c6de9804f89c3a53b6512c2ab425ee522c01e

Branch pushed to git repo; I updated commit sha1. New commits:

[changeset:e32c6de]Orthogonal arrays -- bugfix

comment:4 Changed 6 years ago by git

  • Commit changed from e32c6de9804f89c3a53b6512c2ab425ee522c01e to 59f340b7388df09df8651a509da5919c13b4da26

Branch pushed to git repo; I updated commit sha1. New commits:

[changeset:59f340b]Orthogonal arrays -- doctest

comment:5 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 5 years ago by git

  • Commit changed from 59f340b7388df09df8651a509da5919c13b4da26 to bbc682af4fc2327a108e7f9bc1cbdcc4a9896500

Branch pushed to git repo; I updated commit sha1. New commits:

​a8a2a71Todo notes for further constructions
​941d5a0trac #15268: Rebase on 6.1.beta2
​e02d42ctrac #15286: Reviewer's comments
​47df907trac #15286: Reviewer's comments 2
​49b55b3trac #15286: Rebase on 6.1.beta4
​e0e44f1trac #15286: Fix an encoding problem in the doc
​c67c373trac #15286: Rebase on 6.2.beta0
​dc84bd8Merge branch 'u/ncohen/15286' of git://trac.sagemath.org/sage into 15286
​68cdedfremove the avoid section "Function" in the intial comment and implement
​bbc682atrac #15287: merge with updated #15286

comment:7 Changed 5 years ago by tscrim

  • Branch changed from u/ncohen/15287 to u/tscrim/15287
  • Commit changed from bbc682af4fc2327a108e7f9bc1cbdcc4a9896500 to 8bae37e23c4fd0abcaf9d3fae5f23502556d56e4
  • Reviewers set to Travis Scrimshaw

I've made some review tweaks: some mild formatting, some micro-optimizations, adding doctests. If you're happy with my changes, then positive review.

New commits:

​23bc728Merge branch 'u/ncohen/15287' of trac.sagemath.org:sage into u/tscrim/15287
​8bae37eReview changes to orthogonal_arrays.py.

comment:8 Changed 5 years ago by git

  • Commit changed from 8bae37e23c4fd0abcaf9d3fae5f23502556d56e4 to 849598e3802c167a7247d1a73181516556607950

Branch pushed to git repo; I updated commit sha1. New commits:

​849598eLast minor tweak.

comment:9 Changed 5 years ago by ncohen

  • Status changed from needs_review to positive_review

Wow.

Wow.

Thank you *SO* much for reviewing that. And for adding the definition, sorry for having forgotten !

Thaaaaaaaaaaaaaaaaaanks ! And also for this product(X,repeat=5) that I didn't know.

I will bug Dima with #15288 now. Seems almost doable :-D

Nathann

comment:10 Changed 5 years ago by vbraun

  • Branch changed from u/tscrim/15287 to 849598e3802c167a7247d1a73181516556607950
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.