Opened 6 years ago

Last modified 5 years ago

#15264 new defect

make Mutability class ready to be used

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.4
Component: misc Keywords: mutability doctests
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Looking at the code in sage/structure/mutability.pyx, one notices some things that should be changed:

Update the methods in Mutability: The corresponding methods in sage/structure/sequence.py seem to work nicely. E.g. there self._is_immutable = 1 (in set_immutable) was changed to self._is_immutable = True or self._is_immutable got a return and a try-except (in is_immutable))

Add a doctest in require_mutable and require_immutable that uses the class Mutability.

Add doctests to set_immutable and to is_immutable that really test the code (and note just test the code in sage/structure/sequence.py.

Add doctests to all functions.

Maybe: combine _require_mutable and _require_mutable_cdef with cpdef.

See also the discussion "Mutability" on sage-devel https://groups.google.com/forum/#!topic/sage-devel/dnXSgh56Boo

Change History (3)

comment:1 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:2 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:3 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.