Default embedding of Ljubljana graph (typo)

[ncohen]

The documentation of graphs.LjubljanaGraph claims that the default embedding is obtained from the Heawood graph, while the Heawood embedding is actually the second (and non-default) embedding.

This trivial patch just fixes the typo.

[git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

[changeset:86d9059]	Default embedding of graphs.LjubljanaGraph?()
[changeset:3b15578]	Merging Sage-5.12.beta5, newest dev scripts, and the doctest fixes.
[changeset:1456c52]	Merge branch 'ticket/14482' into public/sage-git/master
[changeset:b890215]	Merge branch 'ticket/14482' into public/sage-git/master
[changeset:d8713eb]	Merge remote-tracking branch 'origin/build_system' into public/sage-git/master
[changeset:970090d]	Merge branch 'u/ohanar/build_system'
[changeset:cf14c84]	Merge branch 'ticket/14482' into public/sage-git/master
[changeset:060184c]	Merge branch 'ticket/14482' into public/sage-git/master
[changeset:b95a820]	Merge branch 'ticket/14482' into public/sage-git/master
[changeset:a10bc4f]	Merge branch 'ticket/14482'

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

[changeset:77c656e]

Default embedding of graphs.LjubljanaGraph?()

[stumpc5]

Hi Nathann -- I am trying to get my first review done and thought this is the right patch to do so.

So, I did git checkout u/ncohen/15228, then saw that you have interchanged the if and the elif, I fixed that, committed the changes, and then tried to push. But then, I got

stumpc5@stumpc5:~/progs/sage$ git push
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 605 bytes | 0 bytes/s, done.
Total 7 (delta 6), reused 0 (delta 0)
remote: FATAL: W refs/heads/u/ncohen/15228 sage stumpc5 DENIED by fallthru
remote: error: hook declined to update refs/heads/u/ncohen/15228
To git@trac.sagemath.org:sage.git
 ! [remote rejected] u/ncohen/15228 -> u/ncohen/15228 (hook declined)
error: failed to push some refs to 'git@trac.sagemath.org:sage.git'

Do you have a simple explanation, or should I post that on sage-devel?

Cheers, Christian

[ncohen]

Do you have a simple explanation, or should I post that on sage-devel?

There are permissions on branches. You can't write on mine, I can't write on yours. If you need to add a commit you need to create your own branch and push it there. Then I don't know what the procedure is exactly : you either change the branch field of this ticket to point to your new branch, or you tell me what your branch is and I add the commit to mine if I agree with it.

Nathann

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​232347b

trac #15228: Default embedding of graphs.LjubljanaGraph?

[ncohen]

Fixed.

[stumpc5]

I overwrote your patch with mine (with the same content, just to check if that works properly from the command line...).

Once the patchbot turns green, I set this to positive review.

---

New commits:

​316016f	Merge branch 'u/ncohen/15228' of trac.sagemath.org:sage into u/ncohen/15228
​615f7f8	fixed a bug if<->elif, beside that: ready to go
​77c656e	Default embedding of graphs.LjubljanaGraph?()

[ncohen]

Okay. When you will be satisfied please set it back to my branch again.

Nathann