Opened 5 years ago
Closed 5 years ago
#15228 closed defect (fixed)
Default embedding of Ljubljana graph (typo)
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.1 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | ||
Authors: | Nathann Cohen | Reviewers: | Christian Stump |
Report Upstream: | N/A | Work issues: | |
Branch: | u/ncohen/15228 (Commits) | Commit: | 232347b0c5b384111a97b432f97b3ce92cf56502 |
Dependencies: | Stopgaps: |
Description
The documentation of graphs.LjubljanaGraph
claims that the default embedding is obtained from the Heawood graph, while the Heawood embedding is actually the second (and non-default) embedding.
This trivial patch just fixes the typo.
Change History (16)
comment:1 Changed 5 years ago by
- Branch set to u/ncohen/15228
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit set to 86d90596012ac3745e8a9dac9da19059b118ed6c
comment:3 Changed 5 years ago by
- Commit changed from 86d90596012ac3745e8a9dac9da19059b118ed6c to 77c656ecd291f2eb13f94d2bf3e262f07c0f7863
Branch pushed to git repo; I updated commit sha1. New commits:
[changeset:77c656e] | Default embedding of graphs.LjubljanaGraph?() |
comment:4 Changed 5 years ago by
- Milestone changed from sage-5.13 to sage-6.0
comment:5 follow-up: ↓ 6 Changed 5 years ago by
Hi Nathann -- I am trying to get my first review done and thought this is the right patch to do so.
So, I did git checkout u/ncohen/15228
, then saw that you have interchanged the if
and the elif
, I fixed that, committed the changes, and then tried to push. But then, I got
stumpc5@stumpc5:~/progs/sage$ git push Counting objects: 13, done. Delta compression using up to 4 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 605 bytes | 0 bytes/s, done. Total 7 (delta 6), reused 0 (delta 0) remote: FATAL: W refs/heads/u/ncohen/15228 sage stumpc5 DENIED by fallthru remote: error: hook declined to update refs/heads/u/ncohen/15228 To git@trac.sagemath.org:sage.git ! [remote rejected] u/ncohen/15228 -> u/ncohen/15228 (hook declined) error: failed to push some refs to 'git@trac.sagemath.org:sage.git'
Do you have a simple explanation, or should I post that on sage-devel
?
Cheers, Christian
comment:6 in reply to: ↑ 5 Changed 5 years ago by
Do you have a simple explanation, or should I post that on
sage-devel
?
There are permissions on branches. You can't write on mine, I can't write on yours. If you need to add a commit you need to create your own branch and push it there. Then I don't know what the procedure is exactly : you either change the branch field of this ticket to point to your new branch, or you tell me what your branch is and I add the commit to mine if I agree with it.
Nathann
comment:7 Changed 5 years ago by
- Commit changed from 77c656ecd291f2eb13f94d2bf3e262f07c0f7863 to 232347b0c5b384111a97b432f97b3ce92cf56502
Branch pushed to git repo; I updated commit sha1. New commits:
232347b | trac #15228: Default embedding of graphs.LjubljanaGraph? |
comment:8 Changed 5 years ago by
Fixed.
comment:9 Changed 5 years ago by
- Branch changed from u/ncohen/15228 to u/stumpc5/ticket/15228
- Created changed from 09/25/13 12:58:12 to 09/25/13 12:58:12
- Modified changed from 12/07/13 14:55:27 to 12/07/13 14:55:27
comment:10 Changed 5 years ago by
- Commit changed from 232347b0c5b384111a97b432f97b3ce92cf56502 to 316016f5c23d8a03f34602b5358b674feb056684
- Reviewers set to Christian Stump
I overwrote your patch with mine (with the same content, just to check if that works properly from the command line...).
Once the patchbot turns green, I set this to positive review.
New commits:
316016f | Merge branch 'u/ncohen/15228' of trac.sagemath.org:sage into u/ncohen/15228 |
615f7f8 | fixed a bug if<->elif, beside that: ready to go |
77c656e | Default embedding of graphs.LjubljanaGraph?() |
comment:11 Changed 5 years ago by
Okay. When you will be satisfied please set it back to my branch again.
Nathann
comment:12 Changed 5 years ago by
- Branch changed from u/stumpc5/ticket/15228 to u/ncohen/ticket/15228
- Commit 316016f5c23d8a03f34602b5358b674feb056684 deleted
comment:13 Changed 5 years ago by
- Branch changed from u/ncohen/ticket/15228 to u/ncohen/15228
- Commit set to 232347b0c5b384111a97b432f97b3ce92cf56502
comment:14 Changed 5 years ago by
- Status changed from needs_review to positive_review
comment:15 Changed 5 years ago by
- Milestone changed from sage-6.0 to sage-6.1
comment:16 Changed 5 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. Last 10 new commits: