Opened 7 years ago

Closed 7 years ago

#15227 closed defect (fixed)

cython debug information directory (patch)

Reported by: felixs Owned by:
Priority: minor Milestone: sage-6.1
Component: cython Keywords: cython debug gdb
Cc: Merged in:
Authors: Felix Salfelder Reviewers: Nathann Cohen
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: u/felixs/cython_dbg (Commits) Commit: f82b4226e689e4d0dc211afc2b8ad6cbfc3031ac
Dependencies: Stopgaps:

Description

There is no way to specify the location where cython writes its debug information (--gdb option). This is required whenever cython is executed from a different directory because of other hardwired paths that cannot be overridden (yet).

Change History (10)

comment:1 Changed 7 years ago by felixs

  • Status changed from new to needs_review

merged upstream

comment:2 Changed 7 years ago by felixs

  • Component changed from packages: standard to cython

comment:3 follow-up: Changed 7 years ago by ncohen

?... Is this patch waiting for a review then O_o

Nathann

comment:4 in reply to: ↑ 3 Changed 7 years ago by felixs

Replying to ncohen:

?... Is this patch waiting for a review

this or a newer version of cython packaged.

then O_o

what does "O_o" mean?

thanks felix

comment:5 follow-up: Changed 7 years ago by ncohen

Ahahahah.. Sorry I had misunderstood something about this ticket. And O_o represents two eyes, one of which is smaller than the other one.

This is amazement : O_O

This is doubt : O_o

This is extreme doubt : O_o_O_o_O

Thuuuuuus I am looking at your patch right now and trying to understand how the new spkg system works. And so far it's muuuuuuuuuuuuuch better :-P

...

Okay okay. Looks like it works, even though I can see this when I reinstall cython :

patching file Cython/Compiler/CmdLine.py
Hunk #2 succeeded at 112 (offset -13 lines).

By the way, is there a command I can run to test this --gdb-output option ?

Nathann

comment:6 in reply to: ↑ 5 ; follow-up: Changed 7 years ago by felixs

Thuuuuuus I am looking at your patch right now and trying to understand how the new spkg system works. And so far it's muuuuuuuuuuuuuch better :-P

i didn't use any such system. please excuse if i missed something.

By the way, is there a command I can run to test this --gdb-output option ?

the patch was successful, if cython --help | grep outdir returns 0. also you can check this

echo "print 42" > file.pyc
cython --gdb file.pyc
cython --gdb-outdir somethingelse
diff -f cython_debug somethingelse/cython_debug # should return zero.

thanks

comment:7 in reply to: ↑ 6 Changed 7 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

i didn't use any such system. please excuse if i missed something.

?

NOnonono I mean that I had not looked at any spkg since the .spkg files. Now the Sage part of the code is in build/pkgs and the sources are stored in upstream, and it is muuuuuch easier to patch spkgs ! I could even write a .cc file I need for Sage which can't be written in Cython directly :-)

the patch was successful, if cython --help | grep outdir returns 0. also you can check this

echo "print 42" > file.pyc
cython --gdb file.pyc
cython --gdb-outdir somethingelse
diff -f cython_debug somethingelse/cython_debug # should return zero.

I replaced that by calls to sage -cython but it all works indeed. Though diff complains that there is no newline at the end of the files the md5sum are the same and the files are created where they should anyway.

Good to go ! And thanks for this occasion to look at the new spkg system, without .spkg files :-P

Nathann

comment:8 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.13 to sage-6.0

comment:9 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:10 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.