Opened 9 years ago
Closed 9 years ago
#15199 closed enhancement (fixed)
Change behavior of blocks_and_cuts_tree on biconnected graphs
Reported by: | David Coudert | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | sage-5.13 |
Component: | graph theory | Keywords: | |
Cc: | Frédéric Chapoton, Nathann Cohen | Merged in: | sage-5.13.beta0 |
Authors: | David Coudert | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
With patch #14871 the blocks_and_cuts_tree
of a biconnected graph (e.g., a PetersenGraph?) is an empty graph. This one line patch forces to have at least one vertex per block.
Attachments (1)
Change History (7)
comment:1 Changed 9 years ago by
Cc: | Frédéric Chapoton Nathann Cohen added |
---|---|
Priority: | major → trivial |
Status: | new → needs_review |
comment:2 Changed 9 years ago by
Status: | needs_review → needs_work |
---|
you should add a doctest to check the new behavior
comment:4 Changed 9 years ago by
Reviewers: | → Nathann Cohen |
---|---|
Status: | needs_review → positive_review |
Okay....
Nathann
comment:5 Changed 9 years ago by
Milestone: | sage-5.12 → sage-5.13 |
---|
comment:6 Changed 9 years ago by
Merged in: | → sage-5.13.beta0 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
It is weird to me to return an empty tree when the graph is biconnected. Also I propose to force adding vertices of type B. But if you think it makes more sense to return an empty tree, then we can forget this patch.
David.