Opened 6 years ago

Closed 6 years ago

#15199 closed enhancement (fixed)

Change behavior of blocks_and_cuts_tree on biconnected graphs

Reported by: dcoudert Owned by:
Priority: trivial Milestone: sage-5.13
Component: graph theory Keywords:
Cc: chapoton, ncohen Merged in: sage-5.13.beta0
Authors: David Coudert Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

With patch #14871 the blocks_and_cuts_tree of a biconnected graph (e.g., a PetersenGraph?) is an empty graph. This one line patch forces to have at least one vertex per block.

Attachments (1)

trac_15199.patch (2.7 KB) - added by dcoudert 6 years ago.
with doctests

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by dcoudert

  • Cc chapoton ncohen added
  • Priority changed from major to trivial
  • Status changed from new to needs_review

It is weird to me to return an empty tree when the graph is biconnected. Also I propose to force adding vertices of type B. But if you think it makes more sense to return an empty tree, then we can forget this patch.

David.

comment:2 Changed 6 years ago by chapoton

  • Status changed from needs_review to needs_work

you should add a doctest to check the new behavior

Changed 6 years ago by dcoudert

with doctests

comment:3 Changed 6 years ago by dcoudert

  • Status changed from needs_work to needs_review

Right. Doctest added.

comment:4 Changed 6 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Okay....

Nathann

comment:5 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.12 to sage-5.13

comment:6 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.13.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.