Opened 9 years ago

Closed 9 years ago

#15199 closed enhancement (fixed)

Change behavior of blocks_and_cuts_tree on biconnected graphs

Reported by: David Coudert Owned by:
Priority: trivial Milestone: sage-5.13
Component: graph theory Keywords:
Cc: Frédéric Chapoton, Nathann Cohen Merged in: sage-5.13.beta0
Authors: David Coudert Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

With patch #14871 the blocks_and_cuts_tree of a biconnected graph (e.g., a PetersenGraph?) is an empty graph. This one line patch forces to have at least one vertex per block.

Attachments (1)

trac_15199.patch (2.7 KB) - added by David Coudert 9 years ago.
with doctests

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by David Coudert

Cc: Frédéric Chapoton Nathann Cohen added
Priority: majortrivial
Status: newneeds_review

It is weird to me to return an empty tree when the graph is biconnected. Also I propose to force adding vertices of type B. But if you think it makes more sense to return an empty tree, then we can forget this patch.

David.

comment:2 Changed 9 years ago by Frédéric Chapoton

Status: needs_reviewneeds_work

you should add a doctest to check the new behavior

Changed 9 years ago by David Coudert

Attachment: trac_15199.patch added

with doctests

comment:3 Changed 9 years ago by David Coudert

Status: needs_workneeds_review

Right. Doctest added.

comment:4 Changed 9 years ago by Nathann Cohen

Reviewers: Nathann Cohen
Status: needs_reviewpositive_review

Okay....

Nathann

comment:5 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.12sage-5.13

comment:6 Changed 9 years ago by Jeroen Demeyer

Merged in: sage-5.13.beta0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.