Opened 8 years ago

Closed 5 years ago

#15190 closed task (duplicate)

Refactor inheritance of padic polynomials and polyniomial rings

Reported by: saraedum Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: padics Keywords:
Cc: roed, jpflori Merged in:
Authors: Julian Rueth Reviewers:
Report Upstream: N/A Work issues: wait for dependency
Branch: u/roed/ticket/15190 (Commits, GitHub, GitLab) Commit: 9e66c00d2e252bcf737d0000bf61b492b6c03b8c
Dependencies: #15232 Stopgaps:

Status badges

Description

Currently, there is no single place where one could add a method so it is available for all p-adic polynomials (this is required for #15188). This ticket streamlines the inheritance graph, removes some unnecessary classes, and adds docstrings in several places.

Change History (16)

comment:1 Changed 8 years ago by saraedum

  • Created changed from 09/12/13 17:45:51 to 09/12/13 17:45:51
  • Milestone changed from sage-5.12 to sage-6.0
  • Modified changed from 09/12/13 17:45:51 to 09/12/13 17:45:51

comment:2 Changed 8 years ago by saraedum

  • Branch set to u/saraedum/ticket/15190

comment:3 Changed 8 years ago by saraedum

  • Modified changed from 09/12/13 18:52:18 to 09/12/13 18:52:18
  • Status changed from new to needs_review

comment:4 Changed 8 years ago by git

  • Commit set to c638bd66c599dfa1694826aaa21283c7a0182ec3

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

[changeset:c638bd6]Merge branch 'u/saraedum/ticket/15232' of ​git://trac.sagemath.org/sage into ticket/15190
[changeset:0b40946]Fixed doc warnings in the dev scripts.
[changeset:b85954a]renamed reset_to_clean_working_directory() to clean() in the dev scripts
[changeset:e113ba9]Fixed a help string in the dev scripts.
[changeset:5e33590]Fixed an error in push()
[changeset:f45cb83]Renamed commands in docstring in sagedev.py
[changeset:95b539e]Made create_ticket() not switch to branch for the ticket automatically.
[changeset:d9fdd82]Renamed several commands in the dev scripts.
[changeset:28d5e0e]Made the sage-dev script more robust.
[changeset:be8e3ff]Speed up local_tickets() by caching trac data

comment:5 Changed 8 years ago by saraedum

  • Dependencies set to #15232
  • Modified changed from 09/27/13 00:15:11 to 09/27/13 00:15:11

comment:6 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:7 Changed 7 years ago by roed

  • Branch changed from u/saraedum/ticket/15190 to u/roed/ticket/15190
  • Commit changed from c638bd66c599dfa1694826aaa21283c7a0182ec3 to 642eab790784848d11c9e546380ca0aa1a8ae62e

Rebased

Last 10 new commits:

​642eab7Merge commit '1f803b655' into ticket/15190
​8c58b70Merge commit '901f95321554' into ticket/15232
​aa65f59Removed removed file from doc.
​f338b7fFix wrong NOTE block.
​fcf6ad2Fix for comparison of padics.
​5f00813Fixes for "sage not defined".
​89ef12dMerge remote-tracking branch 'origin/develop' into ticket/12555
​0e7c964Fixed failing doctest (likely due to #15422).
​7d7ff1fMerge branch 'master' into public/padics/templates-12555
​4b633abFixes for some missing/duplicated chunks.

comment:8 Changed 7 years ago by git

  • Commit changed from 642eab790784848d11c9e546380ca0aa1a8ae62e to 67545d5a155069b7d90a565930f16a195accaf41

Branch pushed to git repo; I updated commit sha1. New commits:

​67545d5Merging in dependency #125232 so that printing works correctly
​49fae49Fixing some conflicts between Jeroen's and Julian's changes

comment:9 Changed 7 years ago by git

  • Commit changed from 67545d5a155069b7d90a565930f16a195accaf41 to 9e66c00d2e252bcf737d0000bf61b492b6c03b8c

Branch pushed to git repo; I updated commit sha1. New commits:

​2f14211Chage polynomial_padic to Cython for upcoming p-adic template ticket
​9e66c00Merge branch 'u/roed/ticket/15232' of git://trac.sagemath.org/sage into ticket/15190

comment:10 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:11 Changed 7 years ago by jpflori

  • Cc jpflori added

comment:12 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:13 Changed 7 years ago by rws

  • Status changed from needs_review to needs_work
  • Work issues set to wait for dependency

comment:14 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:15 Changed 5 years ago by saraedum

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to positive_review

Fixed already in 48da94f7.

comment:16 Changed 5 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.