Opened 9 years ago
Closed 9 years ago
#15145 closed enhancement (fixed)
Add instructions for creating fp groups of order 15 or less
Reported by:  Davis Shurbert  Owned by:  

Priority:  minor  Milestone:  sage6.1 
Component:  documentation  Keywords:  documentation, fp groups 
Cc:  Rob Beezer, Volker Braun, Miguel Marco  Merged in:  
Authors:  Davis Shurbert  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  public/groups/fp_groups15145 (Commits, GitHub, GitLab)  Commit:  d70bb87e65f95897fb40760e732d8d20afa33ed5 
Dependencies:  #14998 #14994 #14813 #14791 #15028  Stopgaps: 
Attachments (2)
Change History (20)
comment:1 Changed 9 years ago by
Status:  new → needs_review 

comment:2 Changed 9 years ago by
Type:  PLEASE CHANGE → enhancement 

comment:3 Changed 9 years ago by
Description:  modified (diff) 

Changed 9 years ago by
Attachment:  trac_15145_fpg_construction_table.patch added 

Changed 9 years ago by
Attachment:  trac_15145reviewts.patch added 

comment:4 Changed 9 years ago by
Reviewers:  → Travis Scrimshaw 

Here's a small review patch which fixes some formatting (including some typos in the full file) and the skips doctests as needed. If you're happy with my changes, then go ahead and set this to positive review.
Best,
Travis
comment:5 Changed 9 years ago by
Description:  modified (diff) 

Status:  needs_review → positive_review 
Summary:  Add instructions for creating fp groups of order 15 or less → Add instructions for creating fp groups of order 15 or less 
Thanks for the fixes, everything looks good to me.
Davis
comment:6 Changed 9 years ago by
Branch:  → u/vbraun/fp_groups_15 

Commit:  → 3b898114f5d6ba65e27fe20a9aae66c6356378ee 
comment:7 Changed 9 years ago by
Resolution:  → fixed 

Status:  positive_review → closed 
comment:8 Changed 9 years ago by
Resolution:  fixed 

Status:  closed → new 
Long doctests fail:
sage t long src/sage/doctest/sources.py ********************************************************************** File "src/sage/doctest/sources.py", line 666, in sage.doctest.sources.FileDocTestSource._test_enough_doctests Failed example: for path, dirs, files in itertools.chain(os.walk('sage'), os.walk('doc')): # long time path = os.path.relpath(path) dirs.sort(); files.sort() for F in files: _, ext = os.path.splitext(F) if ext in ('.py', '.pyx', '.pxi', '.sage', '.spyx', '.rst'): filename = os.path.join(path, F) FDS = FileDocTestSource(filename, DocTestDefaults(long=True,optional=True)) FDS._test_enough_doctests(verbose=False) Expected: There are 7 tests in sage/combinat/dyck_word.py that are not being run There are 18 tests in sage/combinat/partition.py that are not being run There are 15 tests in sage/combinat/permutation.py that are not being run There are 14 tests in sage/combinat/skew_partition.py that are not being run There are 18 tests in sage/combinat/tableau.py that are not being run There are 8 tests in sage/combinat/crystals/tensor_product.py that are not being run There are 15 tests in sage/combinat/root_system/cartan_type.py that are not being run There are 8 tests in sage/combinat/root_system/type_A.py that are not being run There are 8 tests in sage/combinat/root_system/type_G.py that are not being run There are 3 unexpected tests being run in sage/doctest/parsing.py There are 1 unexpected tests being run in sage/doctest/reporting.py There are 9 tests in sage/graphs/graph_plot.py that are not being run There are 3 tests in sage/rings/invariant_theory.py that are not being run Got: There are 7 tests in sage/combinat/dyck_word.py that are not being run There are 18 tests in sage/combinat/partition.py that are not being run There are 15 tests in sage/combinat/permutation.py that are not being run There are 14 tests in sage/combinat/skew_partition.py that are not being run There are 18 tests in sage/combinat/tableau.py that are not being run There are 8 tests in sage/combinat/crystals/tensor_product.py that are not being run There are 15 tests in sage/combinat/root_system/cartan_type.py that are not being run There are 8 tests in sage/combinat/root_system/type_A.py that are not being run There are 8 tests in sage/combinat/root_system/type_G.py that are not being run There are 3 unexpected tests being run in sage/doctest/parsing.py There are 1 unexpected tests being run in sage/doctest/reporting.py There are 9 tests in sage/graphs/graph_plot.py that are not being run There are 3 tests in sage/rings/invariant_theory.py that are not being run There are 4 tests in doc/en/constructions/groups.rst that are not being run **********************************************************************
comment:9 Changed 9 years ago by
Branch:  u/vbraun/fp_groups_15 → public/groups/fp_groups15145 

Commit:  3b898114f5d6ba65e27fe20a9aae66c6356378ee → c2875d7400af36b78d7fce664fcc32387a2a3b61 
Description:  modified (diff) 
Status:  new → needs_review 
Fixed. I still find the line number of that test ironic.
New commits:
c2875d7  Fixed failing doctest.

comment:10 Changed 9 years ago by
Status:  needs_review → positive_review 

comment:11 Changed 9 years ago by
Status:  positive_review → needs_work 

Can you revert the last commit and actually make it run the 4 tests in doc/en/constructions/groups.rst?
comment:12 Changed 9 years ago by
Commit:  c2875d7400af36b78d7fce664fcc32387a2a3b61 → c6c4c46c679241d279387d4cce4ed4e857295a36 

comment:13 Changed 9 years ago by
Status:  needs_work → needs_info 

There's a slight bug with the sources.py
test in that it does not properly realize that
.. skip ::
is suppose to skip the tests (although the doctesting framework does correctly skip it). This means we have to keep the slight formatting error (but not a rst error) of
.. skip ::
but since that was there previously, I've just reverted the change. Do you think that is acceptable?
comment:14 Changed 9 years ago by
you have to break the first line of the bullet point
 bullet line break point: .. skip:: sage: <skipped>
comment:15 Changed 9 years ago by
Commit:  c6c4c46c679241d279387d4cce4ed4e857295a36 → 5c564152477b04be89be67becfdbc6358d549a2f 

Branch pushed to git repo; I updated commit sha1. New commits:
5c56415  break bullet point first line

comment:16 Changed 9 years ago by
Commit:  5c564152477b04be89be67becfdbc6358d549a2f → d70bb87e65f95897fb40760e732d8d20afa33ed5 

Branch pushed to git repo; I updated commit sha1. New commits:
d70bb87  Changed "(You will...output.)" line back.

comment:17 Changed 9 years ago by
Status:  needs_info → positive_review 

Wow, that's a fine nuance and good to know. Thanks Volker.
I just changed a line back to it's original location since I moved it for better formatting with what I knew before comment:14.
comment:18 Changed 9 years ago by
Resolution:  → fixed 

Status:  positive_review → closed 
Replacement patch, fixed wording issues