Opened 8 years ago
Closed 8 years ago
#15144 closed enhancement (fixed)
Binary recurrence sequences
Reported by: | ivogt161 | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.13 |
Component: | number theory | Keywords: | |
Cc: | Merged in: | sage-5.13.beta3 | |
Authors: | Isabel Vogt | Reviewers: | Eric Larson |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This patch implements several methods relating to general integral linear binary recurrence sequences, including a sieve to find perfect powers in integral linear binary recurrence sequences.
Attachments (1)
Change History (10)
comment:1 Changed 8 years ago by
- Reviewers set to Eric Larson
comment:2 follow-up: ↓ 5 Changed 8 years ago by
comment:3 Changed 8 years ago by
- Status changed from new to needs_review
comment:4 Changed 8 years ago by
- Status changed from needs_review to needs_work
comment:5 in reply to: ↑ 2 Changed 8 years ago by
Fixed all issues, except the first documentation issue (which isn't actually an issue; you must have not built the pdf correctly).
Changed 8 years ago by
comment:6 Changed 8 years ago by
- Status changed from needs_work to needs_review
comment:7 Changed 8 years ago by
Looks good now:
- All issues raised above have been fixed satisfactorily. In particular:
sage: S = BinaryRecurrenceSequence(1,1,1,2) sage: S.is_arithmetic() False
sage: S = BinaryRecurrenceSequence(2, -1) sage: S.period(9) 9 sage: S.period(3) 3
- Doctests pass, with full coverage.
- PDF and HTML reference manuals build fine.
comment:8 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:9 Changed 8 years ago by
- Merged in set to sage-5.13.beta3
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Issues with code:
Issues with documentation:
m
in INPUT section, which causes funny output in PDF documentation. Also, there needs to be a note that the answer is cached (c.f. above issue with code).